Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] lintr update leads to failing tests on main #36787

Closed
thisisnic opened this issue Jul 20, 2023 · 0 comments · Fixed by #36788
Closed

[R] lintr update leads to failing tests on main #36787

thisisnic opened this issue Jul 20, 2023 · 0 comments · Fixed by #36788
Assignees
@thisisnic
Labels
Component: R Type: bug
Milestone
14.0.0

Comments

@thisisnic
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

e.g. this failure in a PR entirely unrelated to the file it's flagging the issue with:

https://github.com/apache/arrow/actions/runs/5608822433/jobs/10262194618?pr=36758#step:11:75

Component(s)

R
@thisisnic thisisnic self-assigned this Jul 20, 2023
@github-actions github-actions bot mentioned this issue Jul 20, 2023
Merged
@thisisnic thisisnic mentioned this issue Jul 20, 2023
Merged
thisisnic added a commit that referenced this issue Jul 20, 2023
@thisisnic
GH-36787: [R] lintr update leads to failing tests on main (#36788)
fca6a66 
### What changes are included in this PR?

Turning off the newly introduced indentation linter as it causes test failures, and isn't in sync with styler which we use to style our code.

### Are these changes tested?

No, is linter config.

### Are there any user-facing changes?

No
* Closes: #36787

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 14.0.0 milestone Jul 20, 2023
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@thisisnic @chelseajonesr
apacheGH-36787: [R] lintr update leads to failing tests on main (apac…
3aa5de7 
…he#36788)

### What changes are included in this PR?

Turning off the newly introduced indentation linter as it causes test failures, and isn't in sync with styler which we use to style our code.

### Are these changes tested?

No, is linter config.

### Are there any user-facing changes?

No
* Closes: apache#36787

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@thisisnic @R-JunmingChen
apacheGH-36787: [R] lintr update leads to failing tests on main (apac…
a9c63e2 
…he#36788)

### What changes are included in this PR?

Turning off the newly introduced indentation linter as it causes test failures, and isn't in sync with styler which we use to style our code.

### Are these changes tested?

No, is linter config.

### Are there any user-facing changes?

No
* Closes: apache#36787

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@thisisnic @loicalleyne
apacheGH-36787: [R] lintr update leads to failing tests on main (apac…
f56d0a9 
…he#36788)

### What changes are included in this PR?

Turning off the newly introduced indentation linter as it causes test failures, and isn't in sync with styler which we use to style our code.

### Are these changes tested?

No, is linter config.

### Are there any user-facing changes?

No
* Closes: apache#36787

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36787: [R] lintr update leads to failing tests on main thisisnic/arrow
1 participant
@thisisnic