Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Remove version number which triggers CRAN warning #36883

Closed
thisisnic opened this issue Jul 26, 2023 · 0 comments · Fixed by #36884
Closed

[R] Remove version number which triggers CRAN warning #36883

thisisnic opened this issue Jul 26, 2023 · 0 comments · Fixed by #36884
Assignees
@thisisnic
Labels
Component: R Priority: Critical Type: bug
Milestone
14.0.0

Comments

@thisisnic
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Email from CRAN:

the new arrow has

** using staged installation
Warning in .make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version) :
invalid non-character version specification 'x' (type: double)
Calls: Ops.numeric_version ... as.numeric_version -> numeric_version -> .make_numeric_version
Calls:
1: Ops.numeric_version(dev_version, 100)

warning from

./tools/nixlibs.R:dev_version <- package_version(VERSION)[1, 4]
./tools/nixlibs.R:if (is.na(dev_version) || dev_version < 100) {

which should have "100" instead: can you pls fix?

Component(s)

R
@github-actions github-actions bot mentioned this issue Jul 26, 2023
Merged
thisisnic added a commit that referenced this issue Jul 28, 2023
@thisisnic
GH-36883: [R] Remove version number which triggers CRAN warning (#36884)
8c4941b 
### What changes are included in this PR?

Updates package version number to be character not numeric

### Are these changes tested?

No, is configure scripts

### Are there any user-facing changes?

No
* Closes: #36883

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 14.0.0 milestone Jul 28, 2023
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@thisisnic @R-JunmingChen
apacheGH-36883: [R] Remove version number which triggers CRAN warning (…
2229d80 
…apache#36884)

### What changes are included in this PR?

Updates package version number to be character not numeric

### Are these changes tested?

No, is configure scripts

### Are there any user-facing changes?

No
* Closes: apache#36883

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
thisisnic added a commit to thisisnic/arrow that referenced this issue Aug 23, 2023
@thisisnic
apacheGH-36883: [R] Remove version number which triggers CRAN warning (…
be942e0 
…apache#36884)

### What changes are included in this PR?

Updates package version number to be character not numeric

### Are these changes tested?

No, is configure scripts

### Are there any user-facing changes?

No
* Closes: apache#36883

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@thisisnic @loicalleyne
apacheGH-36883: [R] Remove version number which triggers CRAN warning (…
12a02ed 
…apache#36884)

### What changes are included in this PR?

Updates package version number to be character not numeric

### Are these changes tested?

No, is configure scripts

### Are there any user-facing changes?

No
* Closes: apache#36883

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Priority: Critical Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36883: [R] Remove version number which triggers CRAN warning thisisnic/arrow
1 participant
@thisisnic