You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…36966)
### Rationale for this change
file: light_array.h
The length of the buffers array is 3 (kMaxBuffers).
- buffers_[kValidityBuffer]
- buffers_[kFixedLengthBuffer]
- buffers_[kVariableLengthBuffer]
So when we do the check, the asserted index should be less than 3, not equal to.
In addition, fix the comment line break format problem.
### What changes are included in this PR?
- KeyColumnArray
data and mutable_data ARROW_DCHECK.
- ResizableArrayData class
Comment line break formatting for mutable_data functions
### Are these changes tested?
no, just change assert bound.
### Are there any user-facing changes?
no
* Closes: #36949
Authored-by: light-city <455954986@qq.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
…tion. (apache#36966)
### Rationale for this change
file: light_array.h
The length of the buffers array is 3 (kMaxBuffers).
- buffers_[kValidityBuffer]
- buffers_[kFixedLengthBuffer]
- buffers_[kVariableLengthBuffer]
So when we do the check, the asserted index should be less than 3, not equal to.
In addition, fix the comment line break format problem.
### What changes are included in this PR?
- KeyColumnArray
data and mutable_data ARROW_DCHECK.
- ResizableArrayData class
Comment line break formatting for mutable_data functions
### Are these changes tested?
no, just change assert bound.
### Are there any user-facing changes?
no
* Closes: apache#36949
Authored-by: light-city <455954986@qq.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
light_array KeyColumnArray assert
ARROW_DCHECK(i >= 0 && i <= kMaxBuffers);
may be wrong?when
data(i)
i equl kMaxBuffers, will the buffers_boundary be exceeded?So,this is a bug?
index should [0,1, 2] but not include 3
Component(s)
C++
The text was updated successfully, but these errors were encountered: