Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][Docs]: Audit unit test to detect unreleased allocators globally #37216

Closed
davisusanibar opened this issue Aug 16, 2023 · 0 comments · Fixed by #37498
Closed

[Java][Docs]: Audit unit test to detect unreleased allocators globally #37216

davisusanibar opened this issue Aug 16, 2023 · 0 comments · Fixed by #37498
Assignees
@davisusanibar
Labels
Component: Documentation Component: Java Type: enhancement
Milestone
14.0.0

Comments

@davisusanibar
Copy link
Contributor

Describe the enhancement requested

Current Arrow Java code recommend to close allocator properly, but there are not a cross validation of this recommendation on the unit test implementation.

Enhancement requested:

  1. Implement a global allocator to handle unreleased allocators properly as part of the unit test, or
  2. Define a base class to deal with unreleased allocators properly as part of the unit test, or
  3. Improve error handling for unreleased allocators properly as part of the unit test

Component(s)

Documentation, Java
This was referenced Aug 16, 2023
Closed
Closed
@davisusanibar davisusanibar mentioned this issue Aug 31, 2023
Merged
@lidavidm lidavidm added this to the 14.0.0 milestone Sep 12, 2023
lidavidm added a commit that referenced this issue Sep 12, 2023
@davisusanibar @lidavidm
GH-37216: [Docs] adding documentation to deal with unreleased allocat…
f71594c 
…ors (#37498)

### Rationale for this change

To close #37216 

### What changes are included in this PR?

Documentation added to try to catch unreleased allocations.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #37216

Lead-authored-by: david dali susanibar arce <davi.sarces@gmail.com>
Co-authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@davisusanibar @lidavidm @loicalleyne
apacheGH-37216: [Docs] adding documentation to deal with unreleased a…
cdf880d 
…llocators (apache#37498)

### Rationale for this change

To close apache#37216 

### What changes are included in this PR?

Documentation added to try to catch unreleased allocations.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#37216

Lead-authored-by: david dali susanibar arce <davi.sarces@gmail.com>
Co-authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@davisusanibar @lidavidm @dgreiss
apacheGH-37216: [Docs] adding documentation to deal with unreleased a…
5f16d78 
…llocators (apache#37498)

### Rationale for this change

To close apache#37216 

### What changes are included in this PR?

Documentation added to try to catch unreleased allocations.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#37216

Lead-authored-by: david dali susanibar arce <davi.sarces@gmail.com>
Co-authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davisusanibar davisusanibar

Labels
Component: Documentation Component: Java Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37216: [Docs] adding documentation to deal with unreleased allocators davisusanibar/arrow
2 participants
@lidavidm @davisusanibar