Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Remove support for pickle5 #37244

Closed
danepitkin opened this issue Aug 18, 2023 · 2 comments · Fixed by #37644
Closed

[Python] Remove support for pickle5 #37244

danepitkin opened this issue Aug 18, 2023 · 2 comments · Fixed by #37644
Assignees
@chrisjordansquire
Labels
Component: Python good-first-issue Type: enhancement
Milestone
14.0.0

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

pickle5 is a backport of pickle protocol 5 features from python 3.8.3 to python 3.5, 3.6, and 3.7.[1]

Now that python 3.7 is end-of-life and not supported in Arrow, we can remove all usage of it.

[1] https://pypi.org/project/pickle5/

Component(s)

Python
chrisjordansquire added a commit to chrisjordansquire/arrow that referenced this issue Sep 10, 2023
@chrisjordansquire
Remove pyarrow pickle5 support
2131199 
Resolve issue apache#37244
by removing pickle5 usage in pyarrow.
@chrisjordansquire chrisjordansquire mentioned this issue Sep 10, 2023
Merged
@chrisjordansquire
Copy link
Contributor

Pull request #37644 was created for this issue.

@chrisjordansquire
Copy link
Contributor

@danepitkin Tagging so you're aware of the above PR. Review would be greatly appreciated.

@AlenkaF AlenkaF added this to the 14.0.0 milestone Sep 12, 2023
AlenkaF pushed a commit that referenced this issue Sep 12, 2023
@chrisjordansquire
GH-37244: [Python] Remove support for pickle5 (#37644)
5a1ca69 
Resolve issue #37244 by removing pickle5 usage in pyarrow.

### Rationale for this change

See issue #37244 . 

### What changes are included in this PR?

pickle5 usage is removed from pyarrow . 

### Are these changes tested?

Yes, the python test suite was run. 

### Are there any user-facing changes?

No. 

* Closes: #37244

Authored-by: Chris Jordan-Squire <chris.jordansquire@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
@github-actions github-actions bot mentioned this issue Sep 16, 2023
Merged
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@chrisjordansquire @loicalleyne
apacheGH-37244: [Python] Remove support for pickle5 (apache#37644)
5017457 
Resolve issue apache#37244 by removing pickle5 usage in pyarrow.

### Rationale for this change

See issue apache#37244 . 

### What changes are included in this PR?

pickle5 usage is removed from pyarrow . 

### Are these changes tested?

Yes, the python test suite was run. 

### Are there any user-facing changes?

No. 

* Closes: apache#37244

Authored-by: Chris Jordan-Squire <chris.jordansquire@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@chrisjordansquire @dgreiss
apacheGH-37244: [Python] Remove support for pickle5 (apache#37644)
7c665b9 
Resolve issue apache#37244 by removing pickle5 usage in pyarrow.

### Rationale for this change

See issue apache#37244 . 

### What changes are included in this PR?

pickle5 usage is removed from pyarrow . 

### Are these changes tested?

Yes, the python test suite was run. 

### Are there any user-facing changes?

No. 

* Closes: apache#37244

Authored-by: Chris Jordan-Squire <chris.jordansquire@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisjordansquire chrisjordansquire

Labels
Component: Python good-first-issue Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37244: [Python] Remove support for pickle5 chrisjordansquire/arrow
3 participants
@chrisjordansquire @AlenkaF @danepitkin