Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Update ASV benchmarks to run with latest versions of pyarrow and pandas #37333

Closed
jorisvandenbossche opened this issue Aug 23, 2023 · 1 comment · Fixed by #42089
Closed

[Python] Update ASV benchmarks to run with latest versions of pyarrow and pandas #37333

jorisvandenbossche opened this issue Aug 23, 2023 · 1 comment · Fixed by #42089
Assignees
@amoeba
Labels
Component: Python
Milestone
17.0.0

Comments

@jorisvandenbossche
Copy link
Member

Doing a quick run of our benchmarks (cd arrow/python; asv run --python=same --quick) shows that the main error is relying on pandas.util.testing.rands helper, which no longer exists and we can easily add ourselves.

Goal of this issue is to at least get the benchmarks in a runnable state.
@amoeba amoeba self-assigned this Jun 10, 2024
@amoeba amoeba mentioned this issue Jun 10, 2024
Merged
jorisvandenbossche pushed a commit that referenced this issue Jun 12, 2024
@amoeba
GH-37333: [Python] Replace pandas.util.testing.rands with vendored ve…
383ffe0 
…rsion (#42089)

### Rationale for this change

Fixes #37333.

### What changes are included in this PR?

- Replaces the calls to `pandas.util.testing.rands` with existing `pyarrow.tests.util.rands`
- Updated benchmarks.rst to remove a mention of the now-deprecated `asv dev` command.

### Are these changes tested?

I tested locally in a freshly-created python venv and a conda environment and the benchmarks run without error.

### Are there any user-facing changes?

No.
* GitHub Issue: #37333

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 17.0.0 milestone Jun 12, 2024
@jorisvandenbossche
Copy link
Member Author

Issue resolved by pull request 42089
#42089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amoeba amoeba

Labels
Component: Python
Projects
None yet
Milestone
17.0.0
Development

Successfully merging a pull request may close this issue.

GH-37333: [Python] Replace pandas.util.testing.rands with vendored version amoeba/arrow
2 participants
@amoeba @jorisvandenbossche