Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][GPU] Add CUDA Implementation of Device Event/Stream #37364

Closed
zeroshade opened this issue Aug 24, 2023 · 0 comments · Fixed by #37365
Closed

[C++][GPU] Add CUDA Implementation of Device Event/Stream #37364

zeroshade opened this issue Aug 24, 2023 · 0 comments · Fixed by #37365
Assignees
@zeroshade
Labels
Component: C++ Component: GPU Type: enhancement
Milestone
14.0.0

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

#37040 Added abstractions for Device::SyncEvent and Device::Stream, the next step is to add cuda implementations for these abstractions to the arrow-cuda lib.

Component(s)

C++, GPU
zeroshade added a commit to zeroshade/arrow that referenced this issue Aug 24, 2023
@zeroshade
apacheGH-37364: [C++][GPU] Add CUDA impl of Device Event/Stream
78f6698
@github-actions github-actions bot mentioned this issue Aug 24, 2023
Merged
zeroshade added a commit that referenced this issue Aug 30, 2023
@zeroshade
GH-37364: [C++][GPU] Add CUDA impl of Device Event/Stream (#37365)
3b8ab8e 
### What changes are included in this PR?
Adding `CudaDevice::SyncEvent` and `CudaDevice::Stream` implementations which provide more idiomatic handling of Events and Streams.

### Are these changes tested?
Simple SyncEvent test added. More stream tests still being added.

* Closes: #37364

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 14.0.0 milestone Aug 30, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@zeroshade @loicalleyne
apacheGH-37364: [C++][GPU] Add CUDA impl of Device Event/Stream (apac…
7bbf238 
…he#37365)

### What changes are included in this PR?
Adding `CudaDevice::SyncEvent` and `CudaDevice::Stream` implementations which provide more idiomatic handling of Events and Streams.

### Are these changes tested?
Simple SyncEvent test added. More stream tests still being added.

* Closes: apache#37364

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@zeroshade @dgreiss
apacheGH-37364: [C++][GPU] Add CUDA impl of Device Event/Stream (apac…
5290554 
…he#37365)

### What changes are included in this PR?
Adding `CudaDevice::SyncEvent` and `CudaDevice::Stream` implementations which provide more idiomatic handling of Events and Streams.

### Are these changes tested?
Simple SyncEvent test added. More stream tests still being added.

* Closes: apache#37364

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: C++ Component: GPU Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37364: [C++][GPU] Add CUDA impl of Device Event/Stream zeroshade/arrow
1 participant
@zeroshade