Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Set _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_ = TRUE on CI #37384

Closed
thisisnic opened this issue Aug 25, 2023 · 0 comments · Fixed by #37385
Closed

[R] Set _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_ = TRUE on CI #37384

thisisnic opened this issue Aug 25, 2023 · 0 comments · Fixed by #37385

Comments

@thisisnic
Copy link
Member

Describe the enhancement requested

There are more places in our code where we're failing checks on CRAN but not in our CI as we haven't got _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_ set to TRUE.

Component(s)

R

@thisisnic thisisnic self-assigned this Aug 25, 2023
thisisnic added a commit that referenced this issue Aug 25, 2023
…TRUE on CI (#37385)

### Rationale for this change

Checks fail on CRAN which don't fail on our CI - we should make them fail on our CI instead of just issue a warning

### What changes are included in this PR?

Update settings for R builds so these checks raise error not warning

### Are these changes tested?

Nope 

### Are there any user-facing changes?

No
* Closes: #37384

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 14.0.0 milestone Aug 25, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…TS_ = TRUE on CI (apache#37385)

### Rationale for this change

Checks fail on CRAN which don't fail on our CI - we should make them fail on our CI instead of just issue a warning

### What changes are included in this PR?

Update settings for R builds so these checks raise error not warning

### Are these changes tested?

Nope 

### Are there any user-facing changes?

No
* Closes: apache#37384

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant