Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Valgrind error in TestDeltaByteArrayEncodingDirectPut #37466

Closed
pitrou opened this issue Aug 30, 2023 · 0 comments · Fixed by #37471
Closed

[C++][Parquet] Valgrind error in TestDeltaByteArrayEncodingDirectPut #37466

pitrou opened this issue Aug 30, 2023 · 0 comments · Fixed by #37471
Assignees
@pitrou
Labels
Component: C++ Component: Continuous Integration Component: Parquet Type: bug
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Aug 30, 2023

Describe the bug, including details regarding any error messages, version, and platform.

See failed nightly build at https://github.com/ursacomputing/crossbow/runs/16329060808

Component(s)

C++, Continuous Integration, Parquet
@pitrou pitrou self-assigned this Aug 30, 2023
pitrou added a commit to pitrou/arrow that referenced this issue Aug 30, 2023
@pitrou
apacheGH-37466: [C++][Parquet] Fix Valgrind failure in DELTA_BYTE_ARR…
da33827 
…AY decoder

Avoid skipping any padding bits where reading a one-value data page, as it doesn't contain any block (the value is encoded in the header).
@github-actions github-actions bot mentioned this issue Aug 30, 2023
Merged
pitrou added a commit that referenced this issue Aug 30, 2023
@pitrou
GH-37466: [C++][Parquet] Fix Valgrind failure in DELTA_BYTE_ARRAY dec…
f209161 
…oder (#37471)

### Rationale for this change

Avoid skipping any padding bits where reading a one-value data page, as it doesn't contain any block (the value is encoded in the header).

### Are these changes tested?

Yes, by existing tests and CI jobs.

### Are there any user-facing changes?

No.

* Closes: #37466

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Aug 30, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@pitrou @loicalleyne
apacheGH-37466: [C++][Parquet] Fix Valgrind failure in DELTA_BYTE_ARR…
c562f6e 
…AY decoder (apache#37471)

### Rationale for this change

Avoid skipping any padding bits where reading a one-value data page, as it doesn't contain any block (the value is encoded in the header).

### Are these changes tested?

Yes, by existing tests and CI jobs.

### Are there any user-facing changes?

No.

* Closes: apache#37466

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @dgreiss
apacheGH-37466: [C++][Parquet] Fix Valgrind failure in DELTA_BYTE_ARR…
f9f3469 
…AY decoder (apache#37471)

### Rationale for this change

Avoid skipping any padding bits where reading a one-value data page, as it doesn't contain any block (the value is encoded in the header).

### Are these changes tested?

Yes, by existing tests and CI jobs.

### Are there any user-facing changes?

No.

* Closes: apache#37466

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Component: Continuous Integration Component: Parquet Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37466: [C++][Parquet] Fix Valgrind failure in DELTA_BYTE_ARRAY decoder pitrou/arrow
1 participant
@pitrou