Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Enhance arrow::Datum::ToString #37643

Closed
mapleFU opened this issue Sep 10, 2023 · 1 comment · Fixed by #37646
Closed

[C++] Enhance arrow::Datum::ToString #37643

mapleFU opened this issue Sep 10, 2023 · 1 comment · Fixed by #37646
Assignees
@mapleFU
Labels
Component: C++ Type: enhancement
Milestone
14.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Sep 10, 2023

Describe the enhancement requested

As document says, ::arrow::Datum::ToString only prints the "type" of tagged enum:

  /// \brief Return a string representation of the kind of datum stored.
  std::string ToString() const;

Can we enhance it and try call ToString for RecordBatch, Table, ...etc?

Component(s)

C++
@mapleFU mapleFU changed the title [C++] Enhande arrow::Datum::ToString [C++] Enhance arrow::Datum::ToString Sep 10, 2023
@kou
Copy link
Member

kou commented Sep 11, 2023

+1

@github-actions github-actions bot mentioned this issue Sep 11, 2023
Merged
bkietz pushed a commit that referenced this issue Sep 15, 2023
@mapleFU
GH-37643: [C++] Enhance arrow::Datum::ToString (#37646)
d9ee3a7 
### Rationale for this change

Add print child fields for `arrow::Datum::ToString`. Because previously it just print a type.

### What changes are included in this PR?

Add detail in `arrow::Datum::ToString`

### Are these changes tested?

no

### Are there any user-facing changes?

Yes

* Closes: #37643

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
@bkietz bkietz added this to the 14.0.0 milestone Sep 15, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@mapleFU @loicalleyne
apacheGH-37643: [C++] Enhance arrow::Datum::ToString (apache#37646)
abe14dc 
### Rationale for this change

Add print child fields for `arrow::Datum::ToString`. Because previously it just print a type.

### What changes are included in this PR?

Add detail in `arrow::Datum::ToString`

### Are these changes tested?

no

### Are there any user-facing changes?

Yes

* Closes: apache#37643

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@mapleFU @dgreiss
apacheGH-37643: [C++] Enhance arrow::Datum::ToString (apache#37646)
0e08fda 
### Rationale for this change

Add print child fields for `arrow::Datum::ToString`. Because previously it just print a type.

### What changes are included in this PR?

Add detail in `arrow::Datum::ToString`

### Are these changes tested?

no

### Are there any user-facing changes?

Yes

* Closes: apache#37643

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37643: [C++] Enhance arrow::Datum::ToString mapleFU/arrow
3 participants
@kou @bkietz @mapleFU