Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Expose ArrowArrayConcatenator.Concatenate #37651

Closed
davidhcoe opened this issue Sep 11, 2023 · 0 comments · Fixed by #37652
Closed

[C#] Expose ArrowArrayConcatenator.Concatenate #37651

davidhcoe opened this issue Sep 11, 2023 · 0 comments · Fixed by #37652
Assignees
@davidhcoe
Labels
Component: C# Type: enhancement
Milestone
14.0.0

Comments

@davidhcoe
Copy link
Contributor

Describe the enhancement requested

Other libraries, such as upcoming drivers written in C#, need the ability to concatenate arrays, particularly for metadata calls.

Component(s)

C#
@davidhcoe davidhcoe mentioned this issue Sep 11, 2023
Merged
lidavidm pushed a commit that referenced this issue Oct 6, 2023
@davidhcoe
GH-37651: [C#] expose ArrowArrayConcatenator.Concatenate (#37652)
0d89741 
### Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls. 

### What changes are included in this PR?

Converts a previously internal class and method to a public class and method. 

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

It exposes previously hidden functionality. 

Resolves #37651 

* Closes: #37651

Lead-authored-by: David Coe <coedavid@umich.edu>
Co-authored-by: davidhcoe <13318837+davidhcoe@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 14.0.0 milestone Oct 6, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@davidhcoe
apacheGH-37651: [C#] expose ArrowArrayConcatenator.Concatenate (apach…
524849f 
…e#37652)

### Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls. 

### What changes are included in this PR?

Converts a previously internal class and method to a public class and method. 

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

It exposes previously hidden functionality. 

Resolves apache#37651 

* Closes: apache#37651

Lead-authored-by: David Coe <coedavid@umich.edu>
Co-authored-by: davidhcoe <13318837+davidhcoe@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@davidhcoe @loicalleyne
apacheGH-37651: [C#] expose ArrowArrayConcatenator.Concatenate (apach…
72cca8c 
…e#37652)

### Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls. 

### What changes are included in this PR?

Converts a previously internal class and method to a public class and method. 

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

It exposes previously hidden functionality. 

Resolves apache#37651 

* Closes: apache#37651

Lead-authored-by: David Coe <coedavid@umich.edu>
Co-authored-by: davidhcoe <13318837+davidhcoe@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@davidhcoe @dgreiss
apacheGH-37651: [C#] expose ArrowArrayConcatenator.Concatenate (apach…
12a9e28 
…e#37652)

### Rationale for this change

New C# drivers need the ability to concatenate arrays, particularly for metadata calls. 

### What changes are included in this PR?

Converts a previously internal class and method to a public class and method. 

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

It exposes previously hidden functionality. 

Resolves apache#37651 

* Closes: apache#37651

Lead-authored-by: David Coe <coedavid@umich.edu>
Co-authored-by: davidhcoe <13318837+davidhcoe@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhcoe davidhcoe

Labels
Component: C# Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37651: [C#] expose ArrowArrayConcatenator.Concatenate davidhcoe/arrow
2 participants
@lidavidm @davidhcoe