Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Avoid unnecessary copies in default go allocator #37687

Closed
andrewchambers opened this issue Sep 13, 2023 · 0 comments · Fixed by #37688
Closed

[Go] Avoid unnecessary copies in default go allocator #37687

andrewchambers opened this issue Sep 13, 2023 · 0 comments · Fixed by #37688
Assignees
@andrewchambers
Labels
Component: Go Type: enhancement
Milestone
14.0.0

Comments

@andrewchambers
Copy link
Contributor

Describe the enhancement requested

The default go allocator copies slices in realloc even when there is spare capacity in the provided slice - this leads to much worse performance than necessary in some benchmarks.

Component(s)

Go
andrewchambers added a commit to andrewchambers/arrow that referenced this issue Sep 13, 2023
@andrewchambers
apacheGH-37687: Don't copy in realloc when capacity is sufficient.
a841516 
This removes excessive copies observed in some benchmarks.
@github-actions github-actions bot mentioned this issue Sep 13, 2023
Merged
@zeroshade zeroshade changed the title Avoid unnecessary copies in default go allocator [Go] Avoid unnecessary copies in default go allocator Sep 13, 2023
zeroshade pushed a commit that referenced this issue Sep 13, 2023
@andrewchambers
GH-37687: [Go] Don't copy in realloc when capacity is sufficient. (#3…
15a8ac3 
…7688)

This removes excessive copies observed in some benchmarks.

* Closes: #37687

Authored-by: Andrew Chambers <ac@acha.ninja>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 14.0.0 milestone Sep 13, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@andrewchambers @loicalleyne
apacheGH-37687: [Go] Don't copy in realloc when capacity is sufficien…
38f8ff5 
…t. (apache#37688)

This removes excessive copies observed in some benchmarks.

* Closes: apache#37687

Authored-by: Andrew Chambers <ac@acha.ninja>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@andrewchambers @dgreiss
apacheGH-37687: [Go] Don't copy in realloc when capacity is sufficien…
ac8f80d 
…t. (apache#37688)

This removes excessive copies observed in some benchmarks.

* Closes: apache#37687

Authored-by: Andrew Chambers <ac@acha.ninja>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewchambers andrewchambers

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37687: [Go] Don't copy in realloc when capacity is sufficient. andrewchambers/arrow
2 participants
@zeroshade @andrewchambers