GH-37950: [R] tests fail on R < 4.0 due to test calling data.frame() without specifying stringsAsFactors=FALSE #37951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit test-r-versions |
github-actions
bot
added
Component: R
awaiting committer review
|
Revision: 84582a7 Submitted crossbow builds: ursacomputing/crossbow @ actions-75059b6651
|
paleolimbot
approved these changes
Sep 29, 2023
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1415598. There were 9 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…ame() without specifying stringsAsFactors=FALSE (apache#37951) ### Rationale for this change Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R ### What changes are included in this PR? Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`. ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37950 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…ame() without specifying stringsAsFactors=FALSE (apache#37951) ### Rationale for this change Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R ### What changes are included in this PR? Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`. ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37950 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…ame() without specifying stringsAsFactors=FALSE (apache#37951) ### Rationale for this change Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R ### What changes are included in this PR? Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`. ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37950 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ame() without specifying stringsAsFactors=FALSE (apache#37951) ### Rationale for this change Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R ### What changes are included in this PR? Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`. ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37950 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tests failing on R < 4.0 builds due to the default value of the the
data.frame()parameterstringsAsFactorsbetween older and newer versions of RWhat changes are included in this PR?
Update a test using
data.frame()to manually specify the value ofstringsAsFactorsasFALSE.Are these changes tested?
No
Are there any user-facing changes?
No
data.frame()without specifyingstringsAsFactors=FALSE#37950