Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][C++] Build failure on OpenSuse 15.3 nightly job relating to Parquet FileReader #37952

Closed
thisisnic opened this issue Sep 29, 2023 · 0 comments · Fixed by #38136
Closed

[R][C++] Build failure on OpenSuse 15.3 nightly job relating to Parquet FileReader #37952

thisisnic opened this issue Sep 29, 2023 · 0 comments · Fixed by #38136
Assignees
@paleolimbot
Labels
Component: R Type: bug
Milestone
14.0.0

Comments

@thisisnic
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

e.g. test-r-rstudio-r-base-4.1-opensuse153

[100%] Building CXX object src/arrow/dataset/CMakeFiles/arrow_dataset_objlib.dir/file_parquet.cc.o
/arrow/cpp/src/arrow/dataset/file_parquet.cc: In member function ‘arrow::Result<std::shared_ptr<parquet::arrow::FileReader> > arrow::dataset::ParquetFileFormat::GetReader(const arrow::dataset::FileSource&, const std::shared_ptr<arrow::dataset::ScanOptions>&, const std::shared_ptr<parquet::FileMetaData>&) const’:
/arrow/cpp/src/arrow/dataset/file_parquet.cc:465:10: error: could not convert ‘arrow_reader’ from ‘std::unique_ptr<parquet::arrow::FileReader>’ to ‘arrow::Result<std::shared_ptr<parquet::arrow::FileReader> >’
   return arrow_reader;
          ^~~~~~~~~~~~
make[2]: *** [src/arrow/dataset/CMakeFiles/arrow_dataset_objlib.dir/build.make:244: src/arrow/dataset/CMakeFiles/arrow_dataset_objlib.dir/file_parquet.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:2454: src/arrow/dataset/CMakeFiles/arrow_dataset_objlib.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
**** Error building Arrow C++. 
------------------------- NOTE ---------------------------
There was an issue preparing the Arrow C++ libraries.
See https://arrow.apache.org/docs/r/articles/install.html
---------------------------------------------------------
ERROR: configuration failed for package ‘arrow’
* removing ‘/arrow/r/check/arrow.Rcheck/arrow’

This has been failing for 11 days.

Component(s)

R
@github-actions github-actions bot mentioned this issue Oct 8, 2023
Merged
pitrou pushed a commit that referenced this issue Oct 9, 2023
@paleolimbot
GH-37952: [C++] Make unique->shared explicit to fix build failure on …
ad26f3f 
…at least one compiler (#38136)

### Rationale for this change

The [test-r-rstudio-r-base-4.1-opensuse153](https://github.com/ursacomputing/crossbow/runs/17162402631) nightly has been failing with a compile error for many days.

### What changes are included in this PR?

Made the unique->shared conversion explicit.

### Are these changes tested?

Yes (by existing tests)

### Are there any user-facing changes?

No.
* Closes: #37952

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Oct 9, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@paleolimbot
apacheGH-37952: [C++] Make unique->shared explicit to fix build failu…
148c6b0 
…re on at least one compiler (apache#38136)

### Rationale for this change

The [test-r-rstudio-r-base-4.1-opensuse153](https://github.com/ursacomputing/crossbow/runs/17162402631) nightly has been failing with a compile error for many days.

### What changes are included in this PR?

Made the unique->shared conversion explicit.

### Are these changes tested?

Yes (by existing tests)

### Are there any user-facing changes?

No.
* Closes: apache#37952

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@paleolimbot @loicalleyne
apacheGH-37952: [C++] Make unique->shared explicit to fix build failu…
cd6452a 
…re on at least one compiler (apache#38136)

### Rationale for this change

The [test-r-rstudio-r-base-4.1-opensuse153](https://github.com/ursacomputing/crossbow/runs/17162402631) nightly has been failing with a compile error for many days.

### What changes are included in this PR?

Made the unique->shared conversion explicit.

### Are these changes tested?

Yes (by existing tests)

### Are there any user-facing changes?

No.
* Closes: apache#37952

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @dgreiss
apacheGH-37952: [C++] Make unique->shared explicit to fix build failu…
5b2068b 
…re on at least one compiler (apache#38136)

### Rationale for this change

The [test-r-rstudio-r-base-4.1-opensuse153](https://github.com/ursacomputing/crossbow/runs/17162402631) nightly has been failing with a compile error for many days.

### What changes are included in this PR?

Made the unique->shared conversion explicit.

### Are these changes tested?

Yes (by existing tests)

### Are there any user-facing changes?

No.
* Closes: apache#37952

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Type: bug
Projects
None yet
Milestone
14.0.0
3 participants
@pitrou @paleolimbot @thisisnic