[R] Add dimnames method to Dataset class
#38376
Comments
thisisnic
pushed a commit
that referenced
this issue
Oct 22, 2023
### Rationale for this change Add `dimnames` method so that things like `colnames(ds)` work out of the box on datasets. Inspired by dbplyr's lazy tbl implementation ### What changes are included in this PR? An additional `dimnames` method for Dataset objects ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: #38376 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
…38377) ### Rationale for this change Add `dimnames` method so that things like `colnames(ds)` work out of the box on datasets. Inspired by dbplyr's lazy tbl implementation ### What changes are included in this PR? An additional `dimnames` method for Dataset objects ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: apache#38376 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 25, 2023
…38377) ### Rationale for this change Add `dimnames` method so that things like `colnames(ds)` work out of the box on datasets. Inspired by dbplyr's lazy tbl implementation ### What changes are included in this PR? An additional `dimnames` method for Dataset objects ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: apache#38376 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…38377) ### Rationale for this change Add `dimnames` method so that things like `colnames(ds)` work out of the box on datasets. Inspired by dbplyr's lazy tbl implementation ### What changes are included in this PR? An additional `dimnames` method for Dataset objects ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: apache#38376 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…38377) ### Rationale for this change Add `dimnames` method so that things like `colnames(ds)` work out of the box on datasets. Inspired by dbplyr's lazy tbl implementation ### What changes are included in this PR? An additional `dimnames` method for Dataset objects ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: apache#38376 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
This will also allow
colnames()to just work.The row names, of course are hard to get, though we might take inspiration from dbplyr and simply return
NULLfor that:https://github.com/tidyverse/dbplyr/blob/1e48cfaf795f9101792567bc68ce7d24a19db9d5/R/tbl-lazy.R#L35-L38
Component(s)
R
The text was updated successfully, but these errors were encountered: