Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release][Website] post-03-website.sh uses needless quotation for current.date #38554

Closed
kou opened this issue Nov 2, 2023 · 0 comments · Fixed by #38555
Closed

[Release][Website] post-03-website.sh uses needless quotation for current.date #38554

kou opened this issue Nov 2, 2023 · 0 comments · Fixed by #38555
Assignees
@kou
Labels
Component: Documentation Component: Release Type: bug
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Nov 2, 2023

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/groonga/groonga/blob/8856bb16ca48d3c936eb36e83fd269835ab055d2/CMakeLists.txt#L143

We should not quote the value to process the value as a date value.

GH-37985 has the problem.

Component(s)

Documentation, Release
@kou kou added the Type: bug label Nov 2, 2023
@kou kou changed the title [Release][Website] post-03-website.sh uses needless quotation for curretn.date [Release][Website] post-03-website.sh uses needless quotation for current.date Nov 2, 2023
kou added a commit to kou/arrow that referenced this issue Nov 2, 2023
@kou
apacheGH-38554: [Release][Website] post-03-website.sh doesn't quote c…
848bfb8 
…urrent.date

We should not quote the value to process the value as a date value.
@github-actions github-actions bot mentioned this issue Nov 2, 2023
Merged
@kou kou closed this as completed in #38555 Nov 2, 2023
kou added a commit that referenced this issue Nov 2, 2023
@kou
GH-38554: [Release][Website] post-03-website.sh doesn't quote current…
4fa7f03 
….date (#38555)

### Rationale for this change

We should not quote the value to process the value as a date value.

### What changes are included in this PR?

Remove needless quotation.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: #38554

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Nov 2, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-38554: [Release][Website] post-03-website.sh doesn't quote c…
8c99345 
…urrent.date (apache#38555)

### Rationale for this change

We should not quote the value to process the value as a date value.

### What changes are included in this PR?

Remove needless quotation.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#38554

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38554: [Release][Website] post-03-website.sh doesn't quote c…
0de4f43 
…urrent.date (apache#38555)

### Rationale for this change

We should not quote the value to process the value as a date value.

### What changes are included in this PR?

Remove needless quotation.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#38554

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Documentation Component: Release Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38554: [Release][Website] post-03-website.sh doesn't quote current.date kou/arrow
1 participant
@kou