Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Rename AzurePath to AzureLocation #38758

Closed
kou opened this issue Nov 17, 2023 · 0 comments · Fixed by #38773
Closed

[C++][FS][Azure] Rename AzurePath to AzureLocation #38758

kou opened this issue Nov 17, 2023 · 0 comments · Fixed by #38773
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Nov 17, 2023

Describe the enhancement requested

It's for readability.

See also the discussion about this: #38708 (comment)

We will also rename AzurePath::path_to_file to AzureLoation::path.

Component(s)

C++
@kou kou mentioned this issue Nov 17, 2023
Merged
@kou kou changed the title GH-38699: [C++][FS][Azure] Rename AzurePath to AzureLocation [C++][FS][Azure] Rename AzurePath to AzureLocation Nov 18, 2023
@kou kou mentioned this issue Nov 18, 2023
Closed
kou added a commit to kou/arrow that referenced this issue Nov 18, 2023
@kou
apacheGH-38758: [C++][FS][Azure] Rename AzurePath to AzureLocation
77ba25a 
It's for readability. AzurePath::path_to_file may be confused.
@github-actions github-actions bot mentioned this issue Nov 18, 2023
Merged
kou added a commit that referenced this issue Nov 19, 2023
@kou
GH-38758: [C++][FS][Azure] Rename AzurePath to AzureLocation (#38773)
46c226e 
### Rationale for this change

It's for readability. `AzurePath::path_to_file` may refer a directory but its name includes `file`.

### What changes are included in this PR?

Rename `AzurePath` to `AzureLocation`:
* `AzurePath::path_to_file` -> `AzureLocation::path`
* `AzurePath::path_to_file_parts` -> `AzureLocation::path_parts`
* `AzurePath::full_path` -> `AzureLocation::all`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38758

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Nov 19, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38758: [C++][FS][Azure] Rename AzurePath to AzureLocation (a…
e6403df 
…pache#38773)

### Rationale for this change

It's for readability. `AzurePath::path_to_file` may refer a directory but its name includes `file`.

### What changes are included in this PR?

Rename `AzurePath` to `AzureLocation`:
* `AzurePath::path_to_file` -> `AzureLocation::path`
* `AzurePath::path_to_file_parts` -> `AzureLocation::path_parts`
* `AzurePath::full_path` -> `AzureLocation::all`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38758

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38758: [C++][FS][Azure] Rename AzurePath to AzureLocation kou/arrow
1 participant
@kou