Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Ensure timeout for download.file is set appropriately #38766

Closed
paleolimbot opened this issue Nov 17, 2023 · 0 comments · Fixed by #38767
Closed

[R] Ensure timeout for download.file is set appropriately #38766

paleolimbot opened this issue Nov 17, 2023 · 0 comments · Fixed by #38767
Assignees
@paleolimbot
Labels
Component: R Type: bug
Milestone
14.0.2

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

From the documentation for download.file():

The timeout for many parts of the transfer can be set by the option timeout
which defaults to 60 seconds. This is often insufficient for downloads of large
files (50MB or more) and so should be increased when download.file is used in
packages to do so. Note that the user can set the default timeout by the
environment variable R_DEFAULT_INTERNET_TIMEOUT in recent versions of
R, so to ensure that this is not decreased packages should use something like

    options(timeout = max(300, getOption("timeout")))
  
(It is unrealistic to require download times of less than 1s/MB.)

I recently ran into an issue on macbuilder with adbcsnowflake where the default value of 60 was insufficient to download the Go dependency sources (34 MB). Our Windows static libs are ~70 MB, and so a timeout might have caused the issue we see with R-devel on Windows (Arrow C++ library was not found).

Component(s)

R
@github-actions github-actions bot mentioned this issue Nov 17, 2023
Merged
assignUser pushed a commit that referenced this issue Nov 18, 2023
@paleolimbot
GH-38766: [R] Add timeout option to try_download (#38767)
c6682f1 
### Rationale for this change

The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html

### What changes are included in this PR?

The timeout value is temporarily increased according to guidance in the help for `download.file()`

### Are these changes tested?

Yes, this code runs during install for at least some CI jobs (also used to download cmake)

### Are there any user-facing changes?

No
* Closes: #38766

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 15.0.0 milestone Nov 21, 2023
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Nov 23, 2023
@paleolimbot @thisisnic
apacheGH-38766: [R] Add timeout option to try_download (apache#38767)
5b2587c 
### Rationale for this change

The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html

### What changes are included in this PR?

The timeout value is temporarily increased according to guidance in the help for `download.file()`

### Are these changes tested?

Yes, this code runs during install for at least some CI jobs (also used to download cmake)

### Are there any user-facing changes?

No
* Closes: apache#38766

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser modified the milestones: 15.0.0, 14.0.2 Nov 27, 2023
assignUser pushed a commit to thisisnic/arrow that referenced this issue Nov 28, 2023
@paleolimbot @assignUser
apacheGH-38766: [R] Add timeout option to try_download (apache#38767)
d64051d 
### Rationale for this change

The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html

### What changes are included in this PR?

The timeout value is temporarily increased according to guidance in the help for `download.file()`

### Are these changes tested?

Yes, this code runs during install for at least some CI jobs (also used to download cmake)

### Are there any user-facing changes?

No
* Closes: apache#38766

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
raulcd pushed a commit that referenced this issue Nov 28, 2023
@paleolimbot @raulcd
GH-38766: [R] Add timeout option to try_download (#38767)
d660c9f 
### Rationale for this change

The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html

### What changes are included in this PR?

The timeout value is temporarily increased according to guidance in the help for `download.file()`

### Are these changes tested?

Yes, this code runs during install for at least some CI jobs (also used to download cmake)

### Are there any user-facing changes?

No
* Closes: #38766

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser pushed a commit to assignUser/arrow that referenced this issue Dec 1, 2023
@paleolimbot @assignUser
apacheGH-38766: [R] Add timeout option to try_download (apache#38767)
f9d888d 
### Rationale for this change

The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html

### What changes are included in this PR?

The timeout value is temporarily increased according to guidance in the help for `download.file()`

### Are these changes tested?

Yes, this code runs during install for at least some CI jobs (also used to download cmake)

### Are there any user-facing changes?

No
* Closes: apache#38766

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @dgreiss
apacheGH-38766: [R] Add timeout option to try_download (apache#38767)
dd725d2 
### Rationale for this change

The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html

### What changes are included in this PR?

The timeout value is temporarily increased according to guidance in the help for `download.file()`

### Are these changes tested?

Yes, this code runs during install for at least some CI jobs (also used to download cmake)

### Are there any user-facing changes?

No
* Closes: apache#38766

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Type: bug
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

GH-38766: [R] Add timeout option to try_download paleolimbot/arrow
2 participants
@paleolimbot @assignUser