Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Gandiva] to_date_utf8_utf8_int32 function's suppress_errors parameter causes segfault for non literal input #38879

Closed
niyue opened this issue Nov 25, 2023 · 0 comments · Fixed by #38987
Closed

[C++][Gandiva] to_date_utf8_utf8_int32 function's suppress_errors parameter causes segfault for non literal input #38879

niyue opened this issue Nov 25, 2023 · 0 comments · Fixed by #38987
Assignees
@niyue
Labels
Component: C++ - Gandiva Type: bug
Milestone
15.0.0

Comments

@niyue
Copy link
Contributor

niyue commented Nov 25, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The to_date_utf8_utf8_int32 function in Gandiva should report an invalid input if the third parameter suppress_errors is not an integer 32 literal value. However, currently, if this parameter is not a integer 32 literal, the program will segfault.

Component(s)

C++ - Gandiva
@niyue niyue changed the title [C++][Gandiva] to_date_utf8_utf8_int32 function's third parameter should be a literal [C++][Gandiva] to_date_utf8_utf8_int32 function's suppress_errors parameter should be a literal Nov 25, 2023
@niyue niyue changed the title [C++][Gandiva] to_date_utf8_utf8_int32 function's suppress_errors parameter should be a literal [C++][Gandiva] to_date_utf8_utf8_int32 function's suppress_errors parameter causes segfault for non literal input Nov 25, 2023
@github-actions github-actions bot mentioned this issue Nov 25, 2023
Merged
This was referenced Nov 28, 2023
Closed
Merged
kou pushed a commit that referenced this issue Nov 29, 2023
@niyue
GH-38879: [C++][Gandiva] Fix Gandiva to_date function's validation fo…
d66780d 
…r supress errors parameter (#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: #38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Nov 29, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@niyue @dgreiss
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
ad2e3ac 
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this issue May 14, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
2ffede9 
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this issue May 14, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
d12d36b 
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This was referenced May 14, 2024
Merged
Merged
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this issue May 14, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
41ca59f 
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue May 15, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
c3b368a 
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this issue May 15, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
ee02a9b 
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@github-actions github-actions bot mentioned this issue May 15, 2024
Merged
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue May 16, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
d2e16bf 
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue May 21, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
59d8fba 
…ion for supress errors parameter (apache#38987)

### Rationale for this change
* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

### What changes are included in this PR?
* A bug fix for to_date_utf8_utf8_int32 parameter validation

### Are these changes tested?
Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

### Are there any user-facing changes?
No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk pushed a commit to DenisTarasyuk/arrow that referenced this issue May 22, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
d5b6d06 
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue May 22, 2024
@niyue @DenisTarasyuk
apacheGH-38879: [C++][Gandiva] Fix Gandiva to_date function's validat…
b6d847a 
…ion for supress errors parameter (apache#38987)

* This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input

* A bug fix for to_date_utf8_utf8_int32 parameter validation

Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function

No
* Closes: apache#38879

Authored-by: Yue Ni <niyue.com@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niyue niyue

Labels
Component: C++ - Gandiva Type: bug
Projects
None yet
Milestone
15.0.0
2 participants
@kou @niyue