Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Running tests results in many warnings from dplyr regarding summarise #39076

Closed
paleolimbot opened this issue Dec 5, 2023 · 0 comments · Fixed by #39077
Closed

[R] Running tests results in many warnings from dplyr regarding summarise #39076

paleolimbot opened this issue Dec 5, 2023 · 0 comments · Fixed by #39077
Assignees
@paleolimbot
Labels
Component: R Type: bug
Milestone
14.0.2

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

When we run the tests we get a lot of:

Warning message:
Returning more (or less) than 1 row per `summarise()` group was deprecated in dplyr 1.1.0.
ℹ Please use `reframe()` instead.
ℹ When switching from `summarise()` to `reframe()`, remember that `reframe()` always returns an
  ungrouped data frame and adjust accordingly.
Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated.

These warnings aren't because we are calling dplyr, but because the tests use example data that results in this warning. These warnings are confusing when running the tests and makes real warnings harder to spot!

Component(s)

R
@github-actions github-actions bot mentioned this issue Dec 5, 2023
Merged
@assignUser assignUser added this to the 14.0.2 milestone Dec 5, 2023
paleolimbot added a commit that referenced this issue Dec 5, 2023
@paleolimbot
GH-39076: [R] Fix tests that trigger confusing dplyr warnings (#39077)
2ab2c42 
### Rationale for this change

Running our test suite results in many spurious warnings being printed that make it difficult to spot actual warnings.

### What changes are included in this PR?

The data used for specific tests involving `summarise()` was updated to not trigger the warnings.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #39076

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@paleolimbot paleolimbot modified the milestones: 14.0.2, 15.0.0 Dec 5, 2023
@assignUser assignUser modified the milestones: 15.0.0, 14.0.2 Dec 6, 2023
raulcd pushed a commit that referenced this issue Dec 6, 2023
@paleolimbot @raulcd
GH-39076: [R] Fix tests that trigger confusing dplyr warnings (#39077)
7802c03 
### Rationale for this change

Running our test suite results in many spurious warnings being printed that make it difficult to spot actual warnings.

### What changes are included in this PR?

The data used for specific tests involving `summarise()` was updated to not trigger the warnings.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #39076

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @dgreiss
apacheGH-39076: [R] Fix tests that trigger confusing dplyr warnings (a…
3a102e8 
…pache#39077)

### Rationale for this change

Running our test suite results in many spurious warnings being printed that make it difficult to spot actual warnings.

### What changes are included in this PR?

The data used for specific tests involving `summarise()` was updated to not trigger the warnings.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#39076

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Type: bug
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

GH-39076: [R] Fix tests that trigger confusing dplyr warnings paleolimbot/arrow
2 participants
@paleolimbot @assignUser