Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Enable parallelism for Make based ExternalProjects #39549

Closed
assignUser opened this issue Jan 10, 2024 · 0 comments · Fixed by #39550
Closed

[C++] Enable parallelism for Make based ExternalProjects #39549

assignUser opened this issue Jan 10, 2024 · 0 comments · Fixed by #39550
Assignees
@assignUser
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@assignUser
Copy link
Member

assignUser commented Jan 10, 2024 •
edited
Loading

Describe the enhancement requested

As discoverd in #39522 (comment) the issues with sub-make fragility when passing -jN to the sub-make no longer exists, likely due to our new minimum CMake version 3.16.

So we should be able to remove the workaround from #2779 and gain a speed up.

Component(s)

C++
@assignUser assignUser self-assigned this Jan 10, 2024
@github-actions github-actions bot mentioned this issue Jan 10, 2024
Merged
@kou kou changed the title [C++] Enable parallelism for Make based externalProjects [C++] Enable parallelism for Make based ExternalProjects Jan 10, 2024
assignUser added a commit that referenced this issue Jan 11, 2024
@assignUser
GH-39549: [C++] Pass -jN to make in external projects (#39550)
adef537 
### Rationale for this change

Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16.
### What changes are included in this PR?

Remove special casing from jemalloc, pass -jN to all make based eps.

### Are these changes tested?
CI
* Closes: #39549

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 16.0.0 milestone Jan 11, 2024
assignUser added a commit that referenced this issue Jan 17, 2024
@assignUser
GH-39549: [C++] Pass -jN to make in external projects (#39550)
a97e4c6 
### Rationale for this change

Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16.
### What changes are included in this PR?

Remove special casing from jemalloc, pass -jN to all make based eps.

### Are these changes tested?
CI
* Closes: #39549

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@assignUser @clayburn
apacheGH-39549: [C++] Pass -jN to make in external projects (apache#3…
f1dca90 
…9550)

### Rationale for this change

Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16.
### What changes are included in this PR?

Remove special casing from jemalloc, pass -jN to all make based eps.

### Are these changes tested?
CI
* Closes: apache#39549

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@assignUser @dgreiss
apacheGH-39549: [C++] Pass -jN to make in external projects (apache#3…
3b3e1aa 
…9550)

### Rationale for this change

Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16.
### What changes are included in this PR?

Remove special casing from jemalloc, pass -jN to all make based eps.

### Are these changes tested?
CI
* Closes: apache#39549

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@assignUser @zanmato1984
apacheGH-39549: [C++] Pass -jN to make in external projects (apache#3…
9633c7e 
…9550)

### Rationale for this change

Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16.
### What changes are included in this PR?

Remove special casing from jemalloc, pass -jN to all make based eps.

### Are these changes tested?
CI
* Closes: apache#39549

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@assignUser @thisisnic
apacheGH-39549: [C++] Pass -jN to make in external projects (apache#3…
3fe6a2f 
…9550)

### Rationale for this change

Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16.
### What changes are included in this PR?

Remove special casing from jemalloc, pass -jN to all make based eps.

### Are these changes tested?
CI
* Closes: apache#39549

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39549: [C++] Pass -jN to make in external projects assignUser/arrow
1 participant
@assignUser