Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_ORDERING, SQL_MAX_COLUMNS_IN_TABLE are not supported in SqlInfoBuilder #39558

Closed
thermo911 opened this issue Jan 11, 2024 · 1 comment · Fixed by #39561
Closed

[Java] SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_ORDERING, SQL_MAX_COLUMNS_IN_TABLE are not supported in SqlInfoBuilder #39558

thermo911 opened this issue Jan 11, 2024 · 1 comment · Fixed by #39561
Assignees
@thermo911
Labels
Component: Java Type: bug
Milestone
16.0.0

Comments

@thermo911
Copy link
Contributor

thermo911 commented Jan 11, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Version

15.0.0-SNAPSHOT

Problem

  • org.apache.arrow.flight.sql.SqlInfo.SQL_ALL_TABLES_ARE_SELECTABLE
  • org.apache.arrow.flight.sql.SqlInfo.SQL_NULL_ORDERING
  • org.apache.arrow.flight.sql.SqlInfo.SQL_MAX_COLUMNS_IN_TABLE

are not supported in org.apache.arrow.flight.sql.SqlInfoBuilder

Expected state

  • SqlInfoBuilder has method withSqlAllTablesAreSelectable that accepts single parameter boolean value that specifies whether all tables are selectable.
  • SqlInfoBuilder has method withSqlNullOrdering that accepts single parameter SqlNullOrdering value that specifies ordering of nulls
  • SqlInfoBuilder has methid withSqlMaxColumnsInTable that accepts single parameter long value that specifies maximum number of columns in table.

Component(s)

Java
@thermo911 thermo911 changed the title SqlInfo.SQL_ALL_TABLES_ARE_SELECTABLE is not supported in SqlInfoBuilder SQL_ALL_TABLES_ARE_SELECTABLE and SQL_NULL_ORDERING are not supported in SqlInfoBuilder Jan 11, 2024
@thermo911 thermo911 reopened this Jan 11, 2024
@github-actions github-actions bot mentioned this issue Jan 11, 2024
Merged
@thermo911 thermo911 removed their assignment Jan 11, 2024
@thermo911
Copy link
Contributor Author

I mistakenly removed myself from assignees.

@thermo911 thermo911 changed the title SQL_ALL_TABLES_ARE_SELECTABLE and SQL_NULL_ORDERING are not supported in SqlInfoBuilder SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_ORDERING, SQL_MAX_COLUMNS_IN_TABLE are not supported in SqlInfoBuilder Jan 11, 2024
lidavidm pushed a commit that referenced this issue Jan 12, 2024
@thermo911
GH-39558: [Java] Add SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_ORDERING…
22b42b0 
… and SQL_MAX_COLUMNS_IN_TABLE support to SqlInfoBuilder (#39561)

This PR adds ability to specify `SQL_ALL_TABLES_ARE_SELECTABLE` and `SQL_NULL_ORDERING` metadata in `org.apache.arrow.flight.sql.SqlInfoBuilder`.

### Rationale for this change

Without this change it is impossible to specify whether all tables are selectable, supported null ordering and maximum number of columns in table using `SqlInfoBuilder`.

### What changes are included in this PR?

In this PR two methods are added to `SqlInfoBuilder`:
- `withSqlAllTablesAreSelectable` accepting boolean parameter that specifies whether all tables are selectable
- `withSqlNullOrdering` accepting `org.apache.arrow.flight.sql.impl.FlightSql.SqlNullOrdering` value that specifies supported null ordering
- `withSqlMaxColumnsInTable` accepting long parameter that specifies maximum number of columns in table

### Are these changes tested?

To ensure correctness `org.apache.arrow.flight.TestFlightSql#testGetSqlInfoResultsWithManyArgs` test is added).

### Are there any user-facing changes?

This PR does not contain any breaking changes of user API.

* Closes: #39558

Authored-by: Alexander Blazhkov <ablazhkov@querifylabs.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm changed the title SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_ORDERING, SQL_MAX_COLUMNS_IN_TABLE are not supported in SqlInfoBuilder [Java] SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_ORDERING, SQL_MAX_COLUMNS_IN_TABLE are not supported in SqlInfoBuilder Jan 12, 2024
@lidavidm lidavidm added this to the 16.0.0 milestone Jan 12, 2024
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@thermo911 @clayburn
apacheGH-39558: [Java] Add SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_OR…
959bce9 
…DERING and SQL_MAX_COLUMNS_IN_TABLE support to SqlInfoBuilder (apache#39561)

This PR adds ability to specify `SQL_ALL_TABLES_ARE_SELECTABLE` and `SQL_NULL_ORDERING` metadata in `org.apache.arrow.flight.sql.SqlInfoBuilder`.

### Rationale for this change

Without this change it is impossible to specify whether all tables are selectable, supported null ordering and maximum number of columns in table using `SqlInfoBuilder`.

### What changes are included in this PR?

In this PR two methods are added to `SqlInfoBuilder`:
- `withSqlAllTablesAreSelectable` accepting boolean parameter that specifies whether all tables are selectable
- `withSqlNullOrdering` accepting `org.apache.arrow.flight.sql.impl.FlightSql.SqlNullOrdering` value that specifies supported null ordering
- `withSqlMaxColumnsInTable` accepting long parameter that specifies maximum number of columns in table

### Are these changes tested?

To ensure correctness `org.apache.arrow.flight.TestFlightSql#testGetSqlInfoResultsWithManyArgs` test is added).

### Are there any user-facing changes?

This PR does not contain any breaking changes of user API.

* Closes: apache#39558

Authored-by: Alexander Blazhkov <ablazhkov@querifylabs.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@thermo911 @dgreiss
apacheGH-39558: [Java] Add SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_OR…
dd20ff0 
…DERING and SQL_MAX_COLUMNS_IN_TABLE support to SqlInfoBuilder (apache#39561)

This PR adds ability to specify `SQL_ALL_TABLES_ARE_SELECTABLE` and `SQL_NULL_ORDERING` metadata in `org.apache.arrow.flight.sql.SqlInfoBuilder`.

### Rationale for this change

Without this change it is impossible to specify whether all tables are selectable, supported null ordering and maximum number of columns in table using `SqlInfoBuilder`.

### What changes are included in this PR?

In this PR two methods are added to `SqlInfoBuilder`:
- `withSqlAllTablesAreSelectable` accepting boolean parameter that specifies whether all tables are selectable
- `withSqlNullOrdering` accepting `org.apache.arrow.flight.sql.impl.FlightSql.SqlNullOrdering` value that specifies supported null ordering
- `withSqlMaxColumnsInTable` accepting long parameter that specifies maximum number of columns in table

### Are these changes tested?

To ensure correctness `org.apache.arrow.flight.TestFlightSql#testGetSqlInfoResultsWithManyArgs` test is added).

### Are there any user-facing changes?

This PR does not contain any breaking changes of user API.

* Closes: apache#39558

Authored-by: Alexander Blazhkov <ablazhkov@querifylabs.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@thermo911 @zanmato1984
apacheGH-39558: [Java] Add SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_OR…
47392be 
…DERING and SQL_MAX_COLUMNS_IN_TABLE support to SqlInfoBuilder (apache#39561)

This PR adds ability to specify `SQL_ALL_TABLES_ARE_SELECTABLE` and `SQL_NULL_ORDERING` metadata in `org.apache.arrow.flight.sql.SqlInfoBuilder`.

### Rationale for this change

Without this change it is impossible to specify whether all tables are selectable, supported null ordering and maximum number of columns in table using `SqlInfoBuilder`.

### What changes are included in this PR?

In this PR two methods are added to `SqlInfoBuilder`:
- `withSqlAllTablesAreSelectable` accepting boolean parameter that specifies whether all tables are selectable
- `withSqlNullOrdering` accepting `org.apache.arrow.flight.sql.impl.FlightSql.SqlNullOrdering` value that specifies supported null ordering
- `withSqlMaxColumnsInTable` accepting long parameter that specifies maximum number of columns in table

### Are these changes tested?

To ensure correctness `org.apache.arrow.flight.TestFlightSql#testGetSqlInfoResultsWithManyArgs` test is added).

### Are there any user-facing changes?

This PR does not contain any breaking changes of user API.

* Closes: apache#39558

Authored-by: Alexander Blazhkov <ablazhkov@querifylabs.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@thermo911 @thisisnic
apacheGH-39558: [Java] Add SQL_ALL_TABLES_ARE_SELECTABLE, SQL_NULL_OR…
88155c4 
…DERING and SQL_MAX_COLUMNS_IN_TABLE support to SqlInfoBuilder (apache#39561)

This PR adds ability to specify `SQL_ALL_TABLES_ARE_SELECTABLE` and `SQL_NULL_ORDERING` metadata in `org.apache.arrow.flight.sql.SqlInfoBuilder`.

### Rationale for this change

Without this change it is impossible to specify whether all tables are selectable, supported null ordering and maximum number of columns in table using `SqlInfoBuilder`.

### What changes are included in this PR?

In this PR two methods are added to `SqlInfoBuilder`:
- `withSqlAllTablesAreSelectable` accepting boolean parameter that specifies whether all tables are selectable
- `withSqlNullOrdering` accepting `org.apache.arrow.flight.sql.impl.FlightSql.SqlNullOrdering` value that specifies supported null ordering
- `withSqlMaxColumnsInTable` accepting long parameter that specifies maximum number of columns in table

### Are these changes tested?

To ensure correctness `org.apache.arrow.flight.TestFlightSql#testGetSqlInfoResultsWithManyArgs` test is added).

### Are there any user-facing changes?

This PR does not contain any breaking changes of user API.

* Closes: apache#39558

Authored-by: Alexander Blazhkov <ablazhkov@querifylabs.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thermo911 thermo911

Labels
Component: Java Type: bug
Projects
None yet
Milestone
16.0.0
2 participants
@lidavidm @thermo911