Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] TEST_BINARY=1 verify-release-candidate.sh doesn't use temporary directory #39683

Closed
kou opened this issue Jan 18, 2024 · 0 comments · Fixed by #39684
Closed

[Release] TEST_BINARY=1 verify-release-candidate.sh doesn't use temporary directory #39683

kou opened this issue Jan 18, 2024 · 0 comments · Fixed by #39684
Assignees
@kou
Labels
Component: Developer Tools Type: bug
Milestone
16.0.0

Comments

@kou
Copy link
Member

kou commented Jan 18, 2024

Describe the bug, including details regarding any error messages, version, and platform.

It should use a temporary directory for verifying in clean environment.

Component(s)

Developer Tools
@kou kou added the Type: bug label Jan 18, 2024
kou added a commit to kou/arrow that referenced this issue Jan 18, 2024
@kou
apacheGH-39683: [Release] Use temporary direction with TEST_BINARY=1
93f87ed
@github-actions github-actions bot mentioned this issue Jan 18, 2024
Merged
raulcd pushed a commit that referenced this issue Jan 18, 2024
@kou
GH-39683: [Release] Use temporary direction with TEST_BINARY=1 (#39684)
1f5dece 
### Rationale for this change

We should use temporary directory to verify in clean environment.

### What changes are included in this PR?

Use `ARROW_TMPDIR` for prefix of download directory.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #39683

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd raulcd added this to the 16.0.0 milestone Jan 18, 2024
idailylife pushed a commit to idailylife/arrow that referenced this issue Jan 18, 2024
@kou @idailylife
apacheGH-39683: [Release] Use temporary direction with TEST_BINARY=1 (a…
4903daa 
…pache#39684)

### Rationale for this change

We should use temporary directory to verify in clean environment.

### What changes are included in this PR?

Use `ARROW_TMPDIR` for prefix of download directory.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#39683

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@kou @clayburn
apacheGH-39683: [Release] Use temporary direction with TEST_BINARY=1 (a…
8dcdc83 
…pache#39684)

### Rationale for this change

We should use temporary directory to verify in clean environment.

### What changes are included in this PR?

Use `ARROW_TMPDIR` for prefix of download directory.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#39683

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-39683: [Release] Use temporary direction with TEST_BINARY=1 (a…
75db4af 
…pache#39684)

### Rationale for this change

We should use temporary directory to verify in clean environment.

### What changes are included in this PR?

Use `ARROW_TMPDIR` for prefix of download directory.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#39683

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@kou @zanmato1984
apacheGH-39683: [Release] Use temporary direction with TEST_BINARY=1 (a…
ca15551 
…pache#39684)

### Rationale for this change

We should use temporary directory to verify in clean environment.

### What changes are included in this PR?

Use `ARROW_TMPDIR` for prefix of download directory.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#39683

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@kou @thisisnic
apacheGH-39683: [Release] Use temporary direction with TEST_BINARY=1 (a…
19741d4 
…pache#39684)

### Rationale for this change

We should use temporary directory to verify in clean environment.

### What changes are included in this PR?

Use `ARROW_TMPDIR` for prefix of download directory.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#39683

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Developer Tools Type: bug
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39683: [Release] Use temporary directory with TEST_BINARY=1 kou/arrow
2 participants
@kou @raulcd