Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Remove Static imports for Utf8 Usage #39752

Closed
vibhatha opened this issue Jan 23, 2024 · 3 comments
Closed

[Java] Remove Static imports for Utf8 Usage #39752

vibhatha opened this issue Jan 23, 2024 · 3 comments
Assignees
@vibhatha
Labels
Component: Java Type: enhancement
Milestone
16.0.0

Comments

@vibhatha
Copy link
Collaborator

Describe the enhancement requested

With the errorprone warning fixes, a decision was made to minimize the static imports. And a few more classes which does the UTF8 import in static mode was found in FlightSqlExample, JsonFileReader ArrowFlightJdbcVarCharVectorAccessor.
It would be good to fix these.

Component(s)

Java
@vibhatha vibhatha self-assigned this Jan 23, 2024
@vibhatha
Copy link
Collaborator Author

I will continue to work on these improvements following up reviews in #39529

@vibhatha vibhatha mentioned this issue Jan 23, 2024
Merged
5 tasks
@vibhatha
Copy link
Collaborator Author

I will continue to work on these improvements following up reviews in #39529

I have missed this unfortunately. Creating a smaller PR to fix this.

@vibhatha vibhatha mentioned this issue Mar 20, 2024
Merged
lidavidm pushed a commit that referenced this issue Mar 20, 2024
@vibhatha
GH-39752: [Java] Remove Static imports for Utf8 Usage (#40683)
3e9b94f 
### What changes are included in this PR?

Removing static imports of UTF_8. This has been identified as a minor enhancement as documented here: #39752 and discussed in a review [here](#39529 (comment)). 

### Are these changes tested?

Tested by existing test cases. 

### Are there any user-facing changes?

No
* GitHub Issue: #39752

Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 16.0.0 milestone Mar 20, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 40683
#40683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@lidavidm @vibhatha