Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][C++] Add a GHA job for macOS ARM #40082

Closed
pitrou opened this issue Feb 14, 2024 · 6 comments
Closed

[CI][C++] Add a GHA job for macOS ARM #40082

pitrou opened this issue Feb 14, 2024 · 6 comments
Assignees
@kou
Labels
Component: C++ Component: Continuous Integration Type: enhancement
Milestone
16.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Feb 14, 2024

Describe the enhancement requested

GitHub added availability of macOS ARM (M1) runners a couple of weeks ago for Open Source projects:
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

It would be good to add a CI check for Arrow C++ on those runners.

Component(s)

C++, Continuous Integration
@pitrou
Copy link
Member Author

pitrou commented Feb 14, 2024

@raulcd @kou @assignUser

@kou
Copy link
Member

kou commented Feb 14, 2024 •
edited

Wow!
It seems that @raulcd already opened an issue for this: GH-40077
I close this as duplicated.

@kou kou closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
@pitrou
Copy link
Member Author

pitrou commented Feb 14, 2024

What does #40072 have to do with this?

@assignUser
Copy link
Member

I think this isn't a duplicate. As I understand it #40077 is about replacing the crossbow self-hosted runners with gh runners and this issue is about adding an M1 job to PR ci in apache/arrow (e.g. in cpp.yml)

@assignUser assignUser reopened this Feb 14, 2024
@kou
Copy link
Member

kou commented Feb 14, 2024

What does #40072 have to do with this?

Sorry... I used wrong issue number. GH-40077 is what I want to use.

I think this isn't a duplicate. As I understand it #40077 is about replacing the crossbow self-hosted runners with gh runners and this issue is about adding an M1 job to PR ci in apache/arrow (e.g. in cpp.yml)

Ah, I understand. Sorry for my wrong close.

kou added a commit to kou/arrow that referenced this issue Mar 11, 2024
@kou
apacheGH-40082: [CI][C++] Add a job on ARM64 macOS
f90ce79
@github-actions github-actions bot mentioned this issue Mar 11, 2024
Merged
kou added a commit to kou/arrow that referenced this issue Mar 11, 2024
@kou
apacheGH-40082: [CI][C++] Add a job on ARM64 macOS
13435a3
kou added a commit that referenced this issue Mar 11, 2024
@kou
GH-40082: [CI][C++] Add a job on ARM64 macOS (#40456)
5127ef0 
### Rationale for this change

We can use GitHub hosted M1 macOS runner.

### What changes are included in this PR?

* Add a job on macos-14
* Update expected L2 CPU cache range to 32KiB-12MiB from 32KiB-8MiB because M1 macOS runner has 12MiB
* Disable arrow-s3fs-test for now. It'll be fixed by GH-40410
 
### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #40082

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Mar 11, 2024
@kou
Copy link
Member

kou commented Mar 11, 2024

Issue resolved by pull request 40456
#40456

@kou kou closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Continuous Integration Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
3 participants
@kou @pitrou @assignUser