Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][CMake] Use "RapidJSON" CMake target for RapidJSON #40209

Closed
kou opened this issue Feb 23, 2024 · 1 comment
Closed

[C++][CMake] Use "RapidJSON" CMake target for RapidJSON #40209

kou opened this issue Feb 23, 2024 · 1 comment
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@kou
Copy link
Member

kou commented Feb 23, 2024

Describe the enhancement requested

Because upstream uses "RapidJSON" for CMake target name in its CMake package: https://github.com/Tencent/rapidjson/blob/3f73edae00aba5b0112a80b4d41e6f1ff7d92a3d/CMakeLists.txt#L258

Component(s)

C++
kou added a commit to kou/arrow that referenced this issue Feb 23, 2024
@kou
apacheGH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON
fb55ceb 
Because upstream uses "RapidJSON" for CMake target name.

FindRapidJSONAlt.cmake also provides "RapidJSON" CMake target instead
of just providing RAPIDJSON_INCLUDE_DIR.
kou added a commit to kou/arrow that referenced this issue Feb 23, 2024
@kou
apacheGH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON
7fc8918 
Because upstream uses "RapidJSON" for CMake target name.

FindRapidJSONAlt.cmake also provides "RapidJSON" CMake target instead
of just providing RAPIDJSON_INCLUDE_DIR.
@github-actions github-actions bot mentioned this issue Feb 23, 2024
Merged
@kou kou mentioned this issue Feb 23, 2024
Merged
kou added a commit that referenced this issue Feb 24, 2024
@kou
GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON (#4…
193e39c 
…0210)

### Rationale for this change

Because upstream uses "RapidJSON" for CMake target name.

### What changes are included in this PR?

Rename "rapidjson::rapidjson" to "RapidJSON".

FindRapidJSONAlt.cmake provides "RapidJSON" CMake target instead of just providing RAPIDJSON_INCLUDE_DIR.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #40209

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Feb 24, 2024
@kou
Copy link
Member Author

kou commented Feb 24, 2024

Issue resolved by pull request 40210
#40210

@kou kou closed this as completed Feb 24, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@kou @zanmato1984
apacheGH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJS…
750b8e5 
…ON (apache#40210)

### Rationale for this change

Because upstream uses "RapidJSON" for CMake target name.

### What changes are included in this PR?

Rename "rapidjson::rapidjson" to "RapidJSON".

FindRapidJSONAlt.cmake provides "RapidJSON" CMake target instead of just providing RAPIDJSON_INCLUDE_DIR.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40209

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@kou @thisisnic
apacheGH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJS…
2ce15ed 
…ON (apache#40210)

### Rationale for this change

Because upstream uses "RapidJSON" for CMake target name.

### What changes are included in this PR?

Rename "rapidjson::rapidjson" to "RapidJSON".

FindRapidJSONAlt.cmake provides "RapidJSON" CMake target instead of just providing RAPIDJSON_INCLUDE_DIR.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40209

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
1 participant
@kou