Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Typed arrays should not be nullable, null counts should be correct #40851

Closed
domoritz opened this issue Mar 27, 2024 · 0 comments
Closed

Comments

@domoritz
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

const array = Int32Array.from([1, 12, 34])
const vec1 = arrow.vectorFromArray(array);

console.log(vec1.nullable) // should be false
console.log(vec1.nullCount) // should be 0
const vec2 = arrow.vectorFromArray([1, 2, 3]);
console.log("vec2")
console.log(vec2.nullCount) // should be 0
vec2.set(0, null)
console.log(vec2.nullCount) // should be 1 but is 2

Component(s)

JavaScript

@domoritz domoritz self-assigned this Mar 27, 2024
domoritz added a commit to domoritz/arrow that referenced this issue Mar 27, 2024
domoritz added a commit that referenced this issue Apr 3, 2024
@domoritz domoritz added this to the 16.0.0 milestone Apr 3, 2024
@domoritz domoritz closed this as completed Apr 3, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant