Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Build failure with GCC 7.5.0 #41024

Closed
kou opened this issue Apr 5, 2024 · 2 comments
Closed

[C++] Build failure with GCC 7.5.0 #41024

kou opened this issue Apr 5, 2024 · 2 comments
Assignees
@mapleFU
Labels
Component: C++ Type: bug
Milestone
16.0.0

Comments

@kou
Copy link
Member

kou commented Apr 5, 2024

Describe the bug, including details regarding any error messages, version, and platform.

test-r-rstudio-r-base-4.1-opensuse153

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=62799&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=3367cfe7-6aa5-5a88-c888-e6814d74f6eb&l=1098

/arrow/cpp/src/arrow/io/compressed.cc: In member function ‘arrow::Result<std::shared_ptr<arrow::Buffer> > arrow::io::CompressedInputStream::Impl::Read(int64_t)’:
/arrow/cpp/src/arrow/io/compressed.cc:408:12: error: could not convert ‘buf’ from ‘std::unique_ptr<arrow::ResizableBuffer>’ to ‘arrow::Result<std::shared_ptr<arrow::Buffer> >’
     return buf;
            ^~~

#39807 may be related.

Component(s)

C++
@kou kou added the Type: bug label Apr 5, 2024
@mapleFU
Copy link
Member

mapleFU commented Apr 5, 2024

I'll fix this

@github-actions github-actions bot mentioned this issue Apr 5, 2024
Merged
kou pushed a commit that referenced this issue Apr 5, 2024
@mapleFU
GH-41024: [C++] IO: fixing compiling in gcc 7.5.0 (#41025)
110efed 
### Rationale for this change

Previous pr ( #39807 ) remove std::move when returning value, however, it's not allowed in some old compilers

### What changes are included in this PR?

add std::move for return, and add reason for that

### Are these changes tested?

Should test by other ci

### Are there any user-facing changes?

no

* GitHub Issue: #41024

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member Author

kou commented Apr 5, 2024

Issue resolved by pull request 41025
#41025

@kou kou added this to the 16.0.0 milestone Apr 5, 2024
@kou kou closed this as completed Apr 5, 2024
@mapleFU mapleFU mentioned this issue Apr 10, 2024
Merged
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@mapleFU @tolleybot
apacheGH-41024: [C++] IO: fixing compiling in gcc 7.5.0 (apache#41025)
bc3c8c9 
### Rationale for this change

Previous pr ( apache#39807 ) remove std::move when returning value, however, it's not allowed in some old compilers

### What changes are included in this PR?

add std::move for return, and add reason for that

### Are these changes tested?

Should test by other ci

### Are there any user-facing changes?

no

* GitHub Issue: apache#41024

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
@mapleFU @tolleybot
apacheGH-41024: [C++] IO: fixing compiling in gcc 7.5.0 (apache#41025)
f66c327 
### Rationale for this change

Previous pr ( apache#39807 ) remove std::move when returning value, however, it's not allowed in some old compilers

### What changes are included in this PR?

add std::move for return, and add reason for that

### Are these changes tested?

Should test by other ci

### Are there any user-facing changes?

no

* GitHub Issue: apache#41024

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@mapleFU @rok
apacheGH-41024: [C++] IO: fixing compiling in gcc 7.5.0 (apache#41025)
ba2652d 
### Rationale for this change

Previous pr ( apache#39807 ) remove std::move when returning value, however, it's not allowed in some old compilers

### What changes are included in this PR?

add std::move for return, and add reason for that

### Are these changes tested?

Should test by other ci

### Are there any user-facing changes?

no

* GitHub Issue: apache#41024

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@mapleFU @rok
apacheGH-41024: [C++] IO: fixing compiling in gcc 7.5.0 (apache#41025)
5cc766d 
### Rationale for this change

Previous pr ( apache#39807 ) remove std::move when returning value, however, it's not allowed in some old compilers

### What changes are included in this PR?

add std::move for return, and add reason for that

### Are these changes tested?

Should test by other ci

### Are there any user-facing changes?

no

* GitHub Issue: apache#41024

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@mapleFU @vibhatha
apacheGH-41024: [C++] IO: fixing compiling in gcc 7.5.0 (apache#41025)
fc762be 
### Rationale for this change

Previous pr ( apache#39807 ) remove std::move when returning value, however, it's not allowed in some old compilers

### What changes are included in this PR?

add std::move for return, and add reason for that

### Are these changes tested?

Should test by other ci

### Are there any user-facing changes?

no

* GitHub Issue: apache#41024

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@kou @mapleFU