Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release][Java] Maven version detection in verification script may not work #41280

Closed
kou opened this issue Apr 18, 2024 · 1 comment
Closed

[Release][Java] Maven version detection in verification script may not work #41280

kou opened this issue Apr 18, 2024 · 1 comment
Assignees
@kou
Labels
Component: Java Type: bug
Milestone
16.1.0

Comments

@kou
Copy link
Member

kou commented Apr 18, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Maven may use escape sequence for mvn -v. So $(mvn -v | head -n 1 | awk '{print $3}') may have a escape sequence.

Here is an example case of this:

$ x="$(mvn -v | head -n 1 | awk '{print $3}')" ruby -e 'p ENV["x"]'
"3.8.7\e[m"

Component(s)

Java
@kou kou added the Type: bug label Apr 18, 2024
kou added a commit to kou/arrow that referenced this issue Apr 18, 2024
@kou
apacheGH-41280: [Release][Java] Make Maven version detection more robust
c6c8ffa
@github-actions github-actions bot mentioned this issue Apr 18, 2024
Merged
assignUser pushed a commit that referenced this issue Apr 18, 2024
@kou
GH-41280: [Release][Java] Make Maven version detection more robust (#…
6cebede 
…41281)

### Rationale for this change

If `mvn -v` uses escape sequence, our verification script detects wrong version information.

### What changes are included in this PR?

Ensure disabling escape sequence of `mvn -v`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41280

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 16.1.0 milestone Apr 18, 2024
@assignUser
Copy link
Member

Issue resolved by pull request 41281
#41281

raulcd pushed a commit that referenced this issue Apr 29, 2024
@kou @raulcd
GH-41280: [Release][Java] Make Maven version detection more robust (#…
ee37dd2 
…41281)

### Rationale for this change

If `mvn -v` uses escape sequence, our verification script detects wrong version information.

### What changes are included in this PR?

Ensure disabling escape sequence of `mvn -v`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41280

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@kou @tolleybot
apacheGH-41280: [Release][Java] Make Maven version detection more rob…
97dde91 
…ust (apache#41281)

### Rationale for this change

If `mvn -v` uses escape sequence, our verification script detects wrong version information.

### What changes are included in this PR?

Ensure disabling escape sequence of `mvn -v`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41280

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@kou @vibhatha
apacheGH-41280: [Release][Java] Make Maven version detection more rob…
256d748 
…ust (apache#41281)

### Rationale for this change

If `mvn -v` uses escape sequence, our verification script detects wrong version information.

### What changes are included in this PR?

Ensure disabling escape sequence of `mvn -v`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41280

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Java Type: bug
Projects
None yet
Milestone
16.1.0
Development

No branches or pull requests
2 participants
@kou @assignUser