Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB][CI] Pass strict: true to matlab-actions/run-tests@v2 #41507

Closed
sgilmore10 opened this issue May 2, 2024 · 1 comment
Closed

[MATLAB][CI] Pass strict: true to matlab-actions/run-tests@v2 #41507

sgilmore10 opened this issue May 2, 2024 · 1 comment
Assignees
@sgilmore10
Labels
Component: Continuous Integration Component: MATLAB Type: enhancement
Milestone
17.0.0

Comments

@sgilmore10
Copy link
Member

Describe the enhancement requested

The MATLAB CI jobs should fail if any one of the unit tests issues a warning. Currently, the MATLAB CI jobs only fail if there is a verification failure. Passing the argument strict: true to matlab-actions/run-tests@v2 will ensure MATLAB jobs will fail if a test warning is issued.

See the matlab-actions/run-tests@v2 documentation for more details.

Component(s)

Continuous Integration, MATLAB
@sgilmore10 sgilmore10 self-assigned this May 2, 2024
@github-actions github-actions bot mentioned this issue May 3, 2024
Merged
sgilmore10 added a commit that referenced this issue May 3, 2024
@sgilmore10
GH-41507: [MATLAB][CI] Pass strict: true to `matlab-actions/run-tes…
493d456 
…ts@v2` (#41530)

### Rationale for this change

The MATLAB CI jobs should fail if any one of the unit tests issues a `warning`. Currently, the MATLAB CI jobs only fail if there is a verification failure. Passing the argument `strict: true` to `matlab-actions/run-tests@ v2` will ensure MATLAB jobs will fail if a test warning is issued.

See the [`matlab-actions/run-tests@ v2` documentation](https://github.com/matlab-actions/run-tests/?tab=readme-ov-file#run-matlab-tests) for more details.

### What changes are included in this PR?

1. Pass `strict: true` argument to `matlab-actions/setup-matlab@ v2`

### Are these changes tested?

N/A (relying on existing tests).

### Are there any user-facing changes?

No.

* GitHub Issue: #41507

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Sarah Gilmore <sgilmore@mathworks.com>
@sgilmore10
Copy link
Member Author

Issue resolved by pull request 41530
#41530

@sgilmore10 sgilmore10 added this to the 17.0.0 milestone May 3, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@sgilmore10 @vibhatha
apacheGH-41507: [MATLAB][CI] Pass strict: true to `matlab-actions/r…
c425f96 
…un-tests@v2` (apache#41530)

### Rationale for this change

The MATLAB CI jobs should fail if any one of the unit tests issues a `warning`. Currently, the MATLAB CI jobs only fail if there is a verification failure. Passing the argument `strict: true` to `matlab-actions/run-tests@ v2` will ensure MATLAB jobs will fail if a test warning is issued.

See the [`matlab-actions/run-tests@ v2` documentation](https://github.com/matlab-actions/run-tests/?tab=readme-ov-file#run-matlab-tests) for more details.

### What changes are included in this PR?

1. Pass `strict: true` argument to `matlab-actions/setup-matlab@ v2`

### Are these changes tested?

N/A (relying on existing tests).

### Are there any user-facing changes?

No.

* GitHub Issue: apache#41507

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Sarah Gilmore <sgilmore@mathworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgilmore10 sgilmore10

Labels
Component: Continuous Integration Component: MATLAB Type: enhancement
Projects
Arrow MATLAB
Archived in project
Milestone
17.0.0
Development

No branches or pull requests
1 participant
@sgilmore10