Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Update Unit Tests for Tools Module #42092

Closed
Tracked by #41680
llama90 opened this issue Jun 11, 2024 · 3 comments
Closed
Tracked by #41680

[Java] Update Unit Tests for Tools Module #42092

llama90 opened this issue Jun 11, 2024 · 3 comments

Comments

@llama90
Copy link
Contributor

llama90 commented Jun 11, 2024

Describe the enhancement requested

This is a sub-issue of the issue below.

The unit tests should use the org.junit.jupiter.api package. This issue deals with the tools module.

I will process the modules where the task has been completed first.

Component(s)

Java

@vibhatha
Copy link
Collaborator

@llama90 spotless changes have been merged for the Tools module.

@llama90
Copy link
Contributor Author

llama90 commented Jun 11, 2024

Yes, that's why I'm planning to proceed with this first!

lidavidm pushed a commit that referenced this issue Jun 17, 2024
### Rationale for this change

Update package from JUnit 4(`org.junit`) to JUnit 5(`org.junit.jupiter`).

### What changes are included in this PR?

- [x] Replacing org.junit with org.junit.jupiter.api.
- [x] Updating Assertions.assertXXX to assertXXX using static imports.
- [x] Updating annotations such as `@ Before`, `@ BeforeClass`, `@ After`, `@ AfterClass`, `@ Test`, `@ Rule`, `@ TemporaryFolder`
  - `@ Before` -> `@ BeforeEach`
  - `@ BeforeClass` -> `@ BeforeAll`
  - `@ After` -> `@ AfterEach`
  - `@ AfterClass` -> `@ AfterAll`
  - `@ Test` -> `@ Test` with `org.junit.jupiter`
  - `@ Rule`, `@ TemporaryFolder` -> `@ TempDir`
- [x] Doing self review

### Are these changes tested?

Yes, existing tests have passed.

### Are there any user-facing changes?

No.

* GitHub Issue: #42092

Authored-by: Hyunseok Seo <hsseo0501@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm
Copy link
Member

Issue resolved by pull request 42093
#42093

@lidavidm lidavidm added this to the 17.0.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants