ARROW-12533: [C++] Add random real distribution function #10283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: Below benchmark results are the same, but the total run time differs much. The saved time is from test preparation (generating random bools by calling bernoulli_distribution), not the test itself. Test on Neoverse N1. Clang-10, libstdc++-9. Before: 59.9s total run time After: 1.2s total run time |
|
Tested on Xeon Gold 5218. Clang10, libstdc++-9. Before: 5.4s total run time After: 1.2s total run time |
cyb70289
force-pushed
the
12533-random-real
branch
from
2df3b65
to
3b055f7
Compare
|
Timed running all arrow-compute-*-benchmark tests on x86, clang. Total time drops from 26 to 18 min. |
|
Travis CI passed at https://travis-ci.org/github/cyb70289/arrow/builds/770391382 |
pitrou
reviewed
May 10, 2021
Clang with gnu libstdc++ produces code very slow in generating random real numbers on Arm64. This patch implements three random utilities based on clang libc++: - std::generate_canonical - std::random_real_distribution - std::bernoulli_distribution It brings ~100x speedup on Arm64 and ~8x on x86_64 in generating random reals when build arrow with clang + gnu libstdc++. No influence to gcc + libstdc++, or clang + libc++.
cyb70289
force-pushed
the
12533-random-real
branch
from
3b055f7
to
11abdc4
Compare
|
Thank you @cyb70289 ! |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Clang with gnu libstdc++ produces code very slow in generating random real numbers on Arm64. This patch implements three random utilities based on clang libc++: - std::generate_canonical - std::random_real_distribution - std::bernoulli_distribution It brings ~100x speedup on Arm64 and ~8x on x86_64 in generating random reals when build arrow with clang + gnu libstdc++. No influence to gcc + libstdc++, or clang + libc++. Closes apache#10283 from cyb70289/12533-random-real Authored-by: Yibo Cai <yibo.cai@arm.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang with gnu libstdc++ produces code very slow in generating random
real numbers on Arm64.
This patch implements three random utilities based on clang libc++:
It brings ~100x speedup on Arm64 and ~8x on x86_64 in generating
random reals when build arrow with clang + gnu libstdc++.
No influence to gcc + libstdc++, or clang + libc++.