ARROW-12911: [Python] Export scalar aggregate options to pc.sum #10433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyb70289
commented
Jun 2, 2021
| @@ -836,12 +836,6 @@ cdef class Array(_PandasConvertible): | |||
| result = GetResultValue(self.ap.View(type.sp_type)) | |||
| return pyarrow_wrap_array(result) | |||
|
|
|||
| def sum(self): | |||
There was a problem hiding this comment.
Actually removing this method is a backwards incompatible change. If we want to do that, I think we should deprecate it first (although it is certainly strange to only have a single reduction method exposed here)
For now I would maybe just pass through **kwargs (or leave as as)
There was a problem hiding this comment.
Added kwargs to array.sum(). Tested array.sum(min_count=0).
jorisvandenbossche
approved these changes
Jun 4, 2021
|
Thanks! |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Closes apache#10433 from cyb70289/12911-py-sum Authored-by: Yibo Cai <yibo.cai@arm.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.