Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-13050: [C++][Gandiva] Implement SPACE Hive function on Gandiva #10517

Closed

Conversation

jpedroantunes
Copy link
Contributor

Implement SPACE Hive function on Gandiva

@jpedroantunes jpedroantunes changed the title ARROW-13049: [C++][Gandiva] Implement SPACE Hive function on Gandiva ARROW-13050: [C++][Gandiva] Implement SPACE Hive function on Gandiva Jun 11, 2021
@github-actions
Copy link

@github-actions
Copy link

@jpedroantunes
Copy link
Contributor Author

@augustoasilva can you review it, please?

Copy link
Contributor

@augustoasilva augustoasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is all good, I also tested here locally and everything is fine.

@projjal
Copy link
Contributor

projjal commented Jun 25, 2021

@jpedroantunes build is failing in appveyor. can you look

@jpedroantunes jpedroantunes force-pushed the feature/add-space-function branch 2 times, most recently from b70483e to 7ccebb4 Compare June 30, 2021 00:43
@praveenbingo
Copy link
Contributor

@projjal is appveyor failure expected?

@jpedroantunes
Copy link
Contributor Author

@projjal is appveyor failure expected?

I rebased the branch, and now Appveyor is working perfectly. The other failing builds are unrelated

@jpedroantunes jpedroantunes force-pushed the feature/add-space-function branch 3 times, most recently from c32cdb8 to 4e591ea Compare July 13, 2021 17:13
jvictorhuguenin pushed a commit to s1mbi0se/arrow that referenced this pull request Sep 21, 2021
Implement SPACE Hive function on Gandiva

Closes apache#10517 from jpedroantunes/feature/add-space-function and squashes the following commits:

73281ba <João Pedro> Fix ci build errors
09d8c59 <João Pedro> Add space function implementation

Authored-by: João Pedro <joaop@simbioseventures.com>
Signed-off-by: Praveen <praveen@dremio.com>
(cherry picked from commit 5fcd4d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants