ARROW-13474: [Python] Fix crash in take/filter of empty ExtensionArray #11227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lidavidm
approved these changes
Sep 24, 2021
| RETURN_NOT_OK(VisitTypeInline(*type.storage_type(), this)); | ||
| return Status::OK(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we also add a C++ test here?
arrow/cpp/src/arrow/array/array_test.cc
Line 334 in 87e2ad5
There was a problem hiding this comment.
Added the smallint() extension type to that test.
jorisvandenbossche
force-pushed
the
ARROW-13474
branch
from
ab82de9
to
e93add1
Compare
pitrou
approved these changes
Sep 28, 2021
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
Closes apache#11227 from jorisvandenbossche/ARROW-13474 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.