ARROW-14111: [C++] Add extraction function support for time32/time64 #11229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rok
changed the title
|
|
lidavidm
approved these changes
Sep 24, 2021
| if (timezone.empty()) { | ||
| std::string timezone; | ||
| bool is_timestamp = type.id() == Type::TIMESTAMP; | ||
| if (is_timestamp) { |
There was a problem hiding this comment.
You could make this a compile-time check:
arrow/cpp/src/arrow/type_traits.h
Line 703 in 78ac132
Then presumably any timestamp-related code would get optimized out for the non-timestamp specializations.
There was a problem hiding this comment.
Good point! Changed, please check if it makes sense.
| &options_hms); | ||
| CheckScalarUnary("strftime", time32(TimeUnit::MILLI), times_ms, utf8(), strftime_ms, | ||
| &options_hms); | ||
| CheckScalarUnary("strftime", time32(TimeUnit::SECOND), times_s, utf8(), strftime_s, |
There was a problem hiding this comment.
Should we 1) check what happens for fields like year, and 2) check that %z isn't allowed for times below in StrftimeNoTimezone?
|
@lidavidm thanks for the review :) |
|
Thanks @lidavidm ! :) |
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
This is to resolve [ARROW-14111](https://issues.apache.org/jira/browse/ARROW-14111) Closes apache#11229 from rok/ARROW-14111 Authored-by: Rok <rok@mihevc.org> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve ARROW-14111