Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14223: [C++] add missing third-party dependency #11320

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 5, 2021

In #11268 I neglected to add google_cloud_cpp_storage to the
third-party dependencies.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

@coryan
Copy link
Contributor Author

coryan commented Oct 5, 2021

/FYI @kou

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

In #11268 I neglected to add `google_cloud_cpp_storage` to the
third-party dependencies.
@coryan coryan force-pushed the ARROW-14223-add-google-cloud-cpp-to-thirdparty-dependencies branch from 796a54a to 16f68cf Compare October 5, 2021 14:54
@coryan
Copy link
Contributor Author

coryan commented Oct 5, 2021

The build errors are all related to brew being unable to install grpc. Seems unrelated?

@coryan coryan marked this pull request as ready for review October 5, 2021 16:43
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Yes. They are unrelated.

@kou kou closed this in 01ead8b Oct 5, 2021
@coryan coryan deleted the ARROW-14223-add-google-cloud-cpp-to-thirdparty-dependencies branch October 5, 2021 21:25
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
In apache#11268 I neglected to add `google_cloud_cpp_storage` to the
third-party dependencies.

Closes apache#11320 from coryan/ARROW-14223-add-google-cloud-cpp-to-thirdparty-dependencies

Authored-by: Carlos O'Ryan <coryan@google.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants