Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14230: [C++] Deprecate ArrayBuilder::Advance #11326

Closed

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Oct 5, 2021

No description provided.

@pitrou pitrou requested a review from lidavidm October 5, 2021 15:44
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(Wow, a quick grep of the source shows it's indeed not really tested or used at all.)

@pitrou
Copy link
Member Author

pitrou commented Oct 5, 2021

Looks like GHA is having some issues, we should wait for CI jobs to appear and complete.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

@pitrou pitrou force-pushed the ARROW-14230-array-builder-advance branch from be67abf to 74757e4 Compare October 6, 2021 08:19
@pitrou pitrou closed this in a69884d Oct 6, 2021
@pitrou pitrou deleted the ARROW-14230-array-builder-advance branch October 6, 2021 09:20
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
Closes apache#11326 from pitrou/ARROW-14230-array-builder-advance

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants