ARROW-14352: [IR] Remove schema property from Source #11440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
requested changes
Oct 20, 2021
There was a problem hiding this comment.
I think making this optional for now would be better; in light of the discussion on substrait-io/substrait#51 this property may yet be useful for consumers.
|
@bkietz Fixed up, |
bkietz
approved these changes
Oct 22, 2021
|
Benchmark runs are scheduled for baseline = f2c9d20 and contender = b09914e. b09914e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Nov 3, 2021
This PR removes the schema field from `Source`s, as it is currently unused by both the C++ consumer in progress, as well as the DuckDB producer/consumer (duckdb/duckdb#2331) Closes apache#11440 from cpcloud/ARROW-14352 Authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the schema field from
Sources, as it is currently unused byboth the C++ consumer in progress, as well as the DuckDB producer/consumer
(duckdb/duckdb#2331)