Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels #11536

Closed
wants to merge 1 commit into from
Closed

ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels #11536

wants to merge 1 commit into from

Conversation

lidavidm
Copy link
Member

Now that their respective scalar classes have a common util::string_view view() const getter, we can use that to consolidate some kernel implementations and hopefully shave binary size/build time a little.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-14174

cyb70289
cyb70289 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyb70289
Copy link
Contributor

cyb70289 commented Oct 28, 2021 •
edited
Loading

CI error looks not related, but may deserve deeper investigation.
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/41278276/job/j9k4897e9ppwt2q4#L782
Created jira: https://issues.apache.org/jira/browse/ARROW-14494

@lidavidm
Copy link
Member Author

Thanks for catching that and filing the JIRA.

@lidavidm lidavidm closed this in 2ae84e8 Oct 28, 2021
@ursabot
Copy link

ursabot commented Oct 28, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = faafc51 and contender = 2ae84e8. 2ae84e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️18.97% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.94% ⬆️0.36%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Nov 3, 2021
@lidavidm @ViniciusSouzaRoque
ARROW-14174: [C++] Deduplicate some Decimal/FixedSizeBinary kernels
aa46402 
Now that their respective scalar classes have a common `util::string_view view() const` getter, we can use that to consolidate some kernel implementations and hopefully shave binary size/build time a little.

Closes apache#11536 from lidavidm/arrow-14174

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyb70289 cyb70289 cyb70289 approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidavidm @cyb70289 @ursabot