Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14753: [Doc] Steps in making your first PR - building C++ #11820

Closed
wants to merge 9 commits into from

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Dec 1, 2021

Add Building C++ and PyArrow sections of the New Contributor's guide.

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Copy link
Member

@rok rok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions.

docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
@AlenkaF
Copy link
Member Author

AlenkaF commented Dec 2, 2021

Failing build doesn't seem to be related (RStudio Package Manager error).

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions below. Do you intend to fill the TODOs here or in another PR?

docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very quick first pass!

docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
@AlenkaF
Copy link
Member Author

AlenkaF commented Dec 3, 2021

Thanks everybody for the comments!

Do you intend to fill the TODOs here or in another PR?

I wanted to do it later, but I think I gained some understanding to manage it now. In case the review will take longer as expected I would still think about putting it into a separate PR to make the process faster.

As this is harder topic to write about for me (flags and env variables) it would be great to have some suggestions!

docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/index.rst Outdated Show resolved Hide resolved
@AlenkaF
Copy link
Member Author

AlenkaF commented Dec 6, 2021

Added the suggestions and the TODO parts (flags, env vars and CMake presets). I think this is ready for another round of review @thisisnic @jorisvandenbossche @pitrou Thank you!

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to suggest but otherwise looking good to me

docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/building.rst Outdated Show resolved Hide resolved
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Nic Crane <thisisnic@gmail.com>
@ursabot
Copy link

ursabot commented Dec 8, 2021

Benchmark runs are scheduled for baseline = 6896c6e and contender = 065b1fc. 065b1fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF AlenkaF deleted the ARROW-14753 branch December 8, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants