-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14980: [C++] GCS tests use PYTHON environment variable #11888
ARROW-14980: [C++] GCS tests use PYTHON environment variable #11888
Conversation
server_process_.terminate(); | ||
server_process_.wait(); | ||
} | ||
ASSERT_TRUE(server_process_.valid()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if not? Does the user get an error message stating why the process failed executing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. I fixed the code to print a better message when the python interpreter is not found or fails to start. The python interpreter itself prints a better error message when it manages to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you!
Benchmark runs are scheduled for baseline = 464ccde and contender = 53ab5a0. 53ab5a0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.