Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14980: [C++] GCS tests use PYTHON environment variable #11888

Closed
wants to merge 2 commits into from
Closed

ARROW-14980: [C++] GCS tests use PYTHON environment variable #11888

wants to merge 2 commits into from

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 7, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

@coryan coryan marked this pull request as ready for review December 7, 2021 20:51
server_process_.terminate();
server_process_.wait();
}
ASSERT_TRUE(server_process_.valid());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if not? Does the user get an error message stating why the process failed executing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends. I fixed the code to print a better message when the python interpreter is not found or fails to start. The python interpreter itself prints a better error message when it manages to run.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you!

@pitrou pitrou closed this in 53ab5a0 Dec 9, 2021
@ursabot
Copy link

ursabot commented Dec 9, 2021

Benchmark runs are scheduled for baseline = 464ccde and contender = 53ab5a0. 53ab5a0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.9% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.31% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@coryan coryan deleted the ARROW-14980-gcsfs-tests-use-PYTHON-env-var branch December 9, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants