Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15022: [R] install vignette and installation dev vignette need alt text for images #11972

Closed
wants to merge 2 commits into from
Closed

ARROW-15022: [R] install vignette and installation dev vignette need alt text for images #11972

wants to merge 2 commits into from

Conversation

thisisnic
Copy link
Member

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-15022

@github-actions
Copy link

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

jonkeane
jonkeane requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching these and increasing our accessibility! 💯

r/vignettes/developers/install_details.Rmd Outdated
@@ -57,23 +57,31 @@ correct components are described below.

The diagram below shows how the R package finds a libarrow installation on Windows.

```{r, echo=FALSE, out.width="70%"}
```{r, echo=FALSE, out.width="70%", fig.alt = "Flowchart of libarrow installation on Windows systems - find full description on page"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the full subheader title to this alt text? That way it would be a little bit easier to skim with a screen reader and then get the heading one wants?

r/vignettes/developers/install_details.Rmd Outdated

The diagram below shows how the R package finds a libarrow installation on non-Windows systems.

```{r, echo=FALSE, out.width="70%"}
```{r, echo=FALSE, out.width="70%", fig.alt = "Flowchart of libarrow installation on non-Windows systems - find full description on page"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

jonkeane
jonkeane approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. Thank you for doing this!

@jonkeane jonkeane closed this in 670af33 Dec 17, 2021
@ursabot
Copy link

ursabot commented Dec 17, 2021 •
edited

Benchmark runs are scheduled for baseline = 6e20c6b and contender = 670af33. 670af33 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Finished ⬇️0.44% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/121| 670af338 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/109| 670af338 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/112| 670af338 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/120| 6e20c6b9 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/108| 6e20c6b9 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/111| 6e20c6b9 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

rafael-telles pushed a commit to rafael-telles/arrow that referenced this pull request Dec 20, 2021
@thisisnic @rafael-telles
ARROW-15022: [R] install vignette and installation dev vignette need …
3c640c6 
…alt text for images

Closes apache#11972 from thisisnic/ARROW-15022_alt_text

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkeane jonkeane jonkeane approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thisisnic @ursabot @jonkeane