Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14183: [C++] Improve select_k_unstable performance #12164

Conversation

AlvinJ15
Copy link
Contributor

ARROW-14183: [C++] Improve select_k_unstable performance

@github-actions
Copy link

@AlvinJ15 AlvinJ15 force-pushed the ARROW-14183-Improve_select_k_unstable_performance branch from 3e78d9f to f549a15 Compare January 17, 2022 07:18
@AlvinJ15
Copy link
Contributor Author

@ursabot please benchmark

@ursabot
Copy link

ursabot commented Jan 17, 2022

Benchmark runs are scheduled for baseline = 0c1fd88 and contender = f549a15. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.46% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@pitrou
Copy link
Member

pitrou commented Jan 17, 2022

Are you getting any speedup? The benchmark results don't show any difference.

@AlvinJ15
Copy link
Contributor Author

Are you getting any speedup? The benchmark results don't show any difference.

with just save the ChunkLocation entries in the max-heap there's not show speedup, currently I'm still working on the second part of sort individual batches and merge like Table Sort.

@AlvinJ15
Copy link
Contributor Author

@ursabot please benchmark

@ursabot
Copy link

ursabot commented Feb 14, 2022

Benchmark runs are scheduled for baseline = 5ad5ddc and contender = 3b3e28d. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ElenaHenderson
Copy link
Contributor

@AlvinJ15 @pitrou Benchmark builds are failing because of an issue with aws-sdk-cpp that was fixed in master branch by pinning aws-sdk-cpp version. I recommend getting recent master changes into this branch and rerunning benchmarks.

@AlvinJ15 AlvinJ15 force-pushed the ARROW-14183-Improve_select_k_unstable_performance branch from 3b3e28d to 49c6849 Compare February 15, 2022 01:05
@AlvinJ15
Copy link
Contributor Author

@ursabot please benchmark

@ursabot
Copy link

ursabot commented Feb 15, 2022

Benchmark runs are scheduled for baseline = 7b5efe4 and contender = 49c6849. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️10.0% ⬆️3.21%] ursa-i9-9960x
[Finished ⬇️1.47% ⬆️0.82%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlvinJ15 AlvinJ15 closed this Mar 14, 2022
@AlvinJ15
Copy link
Contributor Author

AlvinJ15 commented Mar 14, 2022

moved to: #12582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants