-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15262: [C++] Create a ToTable sink node #12275
Conversation
|
|
@westonpace I updated the PR with review comments. But there is an issue when we remove the future from the Consuming sync node, the process hangs without finishing. Looking into it. |
I don't think we want to remove the Future from ConsumingSinkNode, but we don't need it in TableSinkNodeOptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a couple nits
LGTM. I think the Dev failure is just because this branch needs to be rebased/it will go away once merged. |
Benchmark runs are scheduled for baseline = 1ff2e19 and contender = 47d5575. 47d5575 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR includes an addition of a Sink node customized to obtain the output from an streaming execution. Closes apache#12275 from vibhatha/arrow-15262 Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This PR includes an addition of a Sink node customized to obtain the output from an streaming execution.