ARROW-15347: [Doc][Guide] Update testing section in new contributors guide #12375
Conversation
|
|
||
| Good to read: | ||
| `Invoking pytest versus python -m pytest <https://docs.pytest.org/en/6.2.x/pythonpath.html#pytest-vs-python-m-pytest>`_ | ||
| (bottom of the page). |
There was a problem hiding this comment.
I am wondering if we should give here a takeaway for our contributors? Or is there not a simple one? (I personally always use pytest .., and not python -m pytest out of habit, and didn't run into problems with my current setup)
There was a problem hiding this comment.
Yeah, I should change python -m pytest to pytest..., also to match https://arrow.apache.org/docs/developers/python.html#unit-testing
As for the takeaway, maybe instead of linking I could add this as a note:
"You can also run the tests with python -m pytest [...]which is almost equivalent to using pytest [...] directly, except that calling via python will also add the current directory to sys.path and can in some cases help if pytest [...] doesn't seem to work."
What do you think?
|
Yes, the R part is only styling (indentation, line wrapping) changes. |
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
jorisvandenbossche
changed the title
|
Benchmark runs are scheduled for baseline = a5dc252 and contender = 0b10a17. 0b10a17 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR adds and restructures the content of the testing section of the New Contributor's Guide.