-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15650: [MATLAB] Rename the MEX gateway function #12424
Conversation
… the function name mexfcn.
…<mex_ext>. Install mexfcn.<mex_ext> and dependencies to a MATLAB package hierarchy: +arrow/+cpp.
… MATLAB package directory.
@nickhaddady, do you have any feedback for this design change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Really like the change to use arrow.cpp.call as it seems to match what is going on in other language bindings for arrow. Think we do need to change the name of the binary mex file that gets built thought to avoid potential future symbol collisions.
Can we merge this? |
Yes, this is ready to merge. Thank you! |
OK. |
Benchmark runs are scheduled for baseline = e989fb3 and contender = 93b192c. 93b192c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Overview
The MATLAB Interface to Arrow contains a MEX function named
mexfcn
to delegate MATLAB calls to C++ functions that implement the functionality.When the interface is installed, the name of the MEX function,
mexfcn
, is on the global MATLAB Search Path. Because the previous name only captured that it is related to MEX functionality, it may cause conflicts with functions outside of the MATLAB Interface to Arrow.Implementation
The following changes were made to address the potential naming conflict:
call
.call.<mex-extension>
+arrow/+cpp
within the installation directory.arrow.cpp.call('<cpp-function-name>', <cpp-function-argument-1>, ..., <cpp-function-argument-N>)
.Testing
ARROW_HOME
andGTEST_ROOT
.Notes
Thank you for working on this pull request with me, @kevingurney!