Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16051: [Gandiva][C++] Fix datediff regression build #12736

Closed
wants to merge 4 commits into from

Conversation

Johnnathanalmeida
Copy link
Contributor

@Johnnathanalmeida Johnnathanalmeida commented Mar 28, 2022

Modifying the order to subtract in Arrow implementation for DateDiff function.

As is:
Hive implementation: 1st parameter - 2st parameter
Arrow implementation: 2st parameter - 1st parameter.

To be:
Hive implementation: 1st parameter - 2st parameter
Arrow implementation: 1st parameter - 2st parameter.

@Johnnathanalmeida
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@Johnnathanalmeida Johnnathanalmeida changed the title [Gandiva][C++] Fix datediff regression build ARROW-16051: [Gandiva][C++] Fix datediff regression build Mar 28, 2022
@github-actions
Copy link

Revision: 4c67b6f

Submitted crossbow builds: ursacomputing/crossbow @ actions-1799

Task Status
java-jars Github Actions

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@Johnnathanalmeida
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 5310673

Submitted crossbow builds: ursacomputing/crossbow @ actions-1802

Task Status
java-jars Github Actions

@Johnnathanalmeida
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 3987925

Submitted crossbow builds: ursacomputing/crossbow @ actions-1803

Task Status
java-jars Github Actions

@pravindra pravindra closed this in 6c10a38 Apr 19, 2022
@ursabot
Copy link

ursabot commented Apr 20, 2022

Benchmark runs are scheduled for baseline = 04e2c92 and contender = 6c10a38. 6c10a38 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.13% ⬆️0.08%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.47% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/538| 6c10a389 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/525| 6c10a389 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/524| 6c10a389 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/535| 6c10a389 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/537| 04e2c929 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/524| 04e2c929 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/523| 04e2c929 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/534| 04e2c929 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants