Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16261: [C++] Fix DeleteDirContents on HDFS with missing_dir_ok=True #12943

Closed

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Apr 21, 2022

Also improve errno propagation from HDFS-related errors.

@pitrou pitrou requested a review from westonpace April 21, 2022 09:09
@pitrou
Copy link
Member Author

pitrou commented Apr 21, 2022

@github-actions crossbow submit hdfs

@github-actions
Copy link

@github-actions
Copy link

Revision: 0741251

Submitted crossbow builds: ursacomputing/crossbow @ actions-1893

Task Status
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had mistakenly assumed that hdfs tests were part of the regular CI.

cpp/src/arrow/filesystem/hdfs.cc Outdated Show resolved Hide resolved
pitrou and others added 2 commits April 22, 2022 18:35
…True

Also improve errno propagation from HDFS-related errors.
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@kszucs kszucs force-pushed the ARROW-16261-hdfs-delete-dir-contents branch from ccc1ea2 to 5a5756d Compare April 22, 2022 16:35
@kszucs kszucs closed this in c04c3ff Apr 23, 2022
@pitrou pitrou deleted the ARROW-16261-hdfs-delete-dir-contents branch April 23, 2022 09:45
@ursabot
Copy link

ursabot commented Apr 28, 2022

Benchmark runs are scheduled for baseline = fd5f28e and contender = c04c3ff. c04c3ff is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.34% ⬆️0.08%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/610| c04c3ff2 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/598| c04c3ff2 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/597| c04c3ff2 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/608| c04c3ff2 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/609| fd5f28ec ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/597| fd5f28ec test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/596| fd5f28ec ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/607| fd5f28ec ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants