ARROW-16325: [R] Add task for R package with gcc12 #12992
Conversation
|
|
|
|
|
@github-actions crossbow submit test-r-gcc-12 |
|
Revision: 6ecab73 Submitted crossbow builds: ursacomputing/crossbow @ actions-1956
|
|
@jonkeane the gcc12 check appears to be clean! |
| ci: github | ||
| template: docker-tests/github.linux.yml | ||
| params: | ||
| env: | ||
| UBUNTU: 22.04 | ||
| GCC_VERSION: 11 | ||
| GCC_VERSION: 12 |
There was a problem hiding this comment.
Do we know if we have gcc 11 coverage in a different build? I can look and see if you don't off the top of your head. But if we don't we might want to duplicate these and do both 11 and 12.
dev/tasks/tasks.yml
Outdated
| ci: github | ||
| template: docker-tests/github.linux.yml | ||
| params: | ||
| env: | ||
| UBUNTU: 22.04 | ||
| GCC_VERSION: 11 | ||
| GCC_VERSION: 12 | ||
| # S3 support is not buildable with gcc11 right now | ||
| flags: '-e ARROW_S3=OFF' |
There was a problem hiding this comment.
Would you mind also trying to drop this line and see if it builds? I suspect it won't, but it's possible that the aws sdk + gcc build issues have been resolved by now (and we bumped the sdk version enough that we don't run into the old ones)
There was a problem hiding this comment.
+1, you can see gcc 12 here: https://github.com/ursacomputing/crossbow/runs/6164317428?check_suite_focus=true#step:6:51
I feel better submitting to CRAN now that this has been done.
If you wanted to upstream this to rhub, note that CRAN runs GCC 12 in the debian-gcc-devel build only; the fedora devel build and debian release and patched are still using GCC 11: https://cran.r-project.org/web/checks/check_flavors.html. This job runs on ubuntu so it's not identical.
|
@github-actions crossbow submit test-r-gcc-11 test-r-gcc-12 |
|
Revision: af50e4e Submitted crossbow builds: ursacomputing/crossbow @ actions-1981
|
There was a problem hiding this comment.
OOOH nice to see that S3 works too!
I'm going to go ahead and merge this, but will also create a jira for upstreaming this change to rhub + have us use that when it's ready.
|
Benchmark runs are scheduled for baseline = 24f3722 and contender = d927772. d927772 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.